Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting a thread on an edited message will render a wrong thread summary (non-persistent) #22162

Closed
janogarcia opened this issue May 12, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2369
Closed

Starting a thread on an edited message will render a wrong thread summary (non-persistent) #22162

janogarcia opened this issue May 12, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2369
Assignees
@t3chguy
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@janogarcia
Copy link

Steps to reproduce

  1. Click on "Reply in thread" on an edited message.

Outcome

What did you expect?

The thread summary to not be rendered until I post the reply.

What happened instead?

A thread summary is generated as soon as I clicked on "Reply in thread" displaying the contents of the root message.

Element 5 | 🧪 Playground Non-encrypted

Operating system

macOS

Browser information

Chrome 101

URL for webapp

develop.element.io

Application version

Element version: 479d4bf-react-fbb8581f779e-js-34cfa511049e Olm version: 3.2.8

Homeserver

matrix.org

Will you send logs?

No
@SimonBrandner SimonBrandner added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels May 12, 2022
@t3chguy t3chguy self-assigned this May 13, 2022
@t3chguy t3chguy mentioned this issue May 13, 2022
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue May 28, 2022
@su-ex
Merge tag 'v18.0.0' into sc
4a5ee08 
* Implement changes to MSC2285 (private read receipts) ([\matrix-org#2221](matrix-org#2221)).
* Add support for HTML renderings of room topics ([\matrix-org#2272](matrix-org#2272)).
* Add stopClient parameter to MatrixClient::logout ([\matrix-org#2367](matrix-org#2367)).
* registration: add function to re-request email token ([\matrix-org#2357](matrix-org#2357)).
* Remove hacky custom status feature ([\matrix-org#2350](matrix-org#2350)).
* Remove default push rule override for MSC1930 ([\matrix-org#2376](matrix-org#2376)). Fixes element-hq/element-web#15439.
* Tweak thread creation & event adding to fix bugs around relations ([\matrix-org#2369](matrix-org#2369)). Fixes element-hq/element-web#22162 and element-hq/element-web#22180.
* Prune both clear & wire content on redaction ([\matrix-org#2346](matrix-org#2346)). Fixes element-hq/element-web#21929.
* MSC3786: Add a default push rule to ignore `m.room.server_acl` events ([\matrix-org#2333](matrix-org#2333)). Fixes element-hq/element-web#20788.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweak thread creation & event adding to fix bugs around relations matrix-org/matrix-js-sdk
3 participants
@janogarcia @t3chguy @SimonBrandner