Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward dialog has no video controls when forwarding videos #23459

Closed
turt2live opened this issue Oct 11, 2022 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11025
Closed

Forward dialog has no video controls when forwarding videos #23459

turt2live opened this issue Oct 11, 2022 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11025
Assignees
@t3chguy
Labels
A-Media A-Message-Forwarding O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Send a video into a room
  2. Menu -> Forward
  3. Try to pause the thing as it plays in the dialog

Outcome

What did you expect?

For the video to not be playing or to be pausable.

What happened instead?

It was playing and could not be paused. I think it might have been playing because of autoplay gifs & videos being enabled on my account? Either way, would expect it to not autoplay in this case or at least be something which can be paused.

Operating system

Windows 10

Application version

Nightly (2022-10-11)

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

No
@SimonBrandner SimonBrandner added A-Media O-Occasional Affects or can be seen by some users regularly or most users rarely A-Message-Forwarding S-Tolerable Low/no impact on users S-Minor Impairs non-critical functionality or suitable workarounds exist good first issue Good for newcomers and removed S-Tolerable Low/no impact on users labels Oct 11, 2022
@t3chguy
Copy link
Member

t3chguy commented Oct 12, 2022

This is due to the pointer-events: none; - we should probably inhibit auto-play instead of reverting that

@t3chguy t3chguy added X-Needs-Design and removed good first issue Good for newcomers labels Oct 12, 2022
@t3chguy t3chguy self-assigned this Jun 1, 2023
@t3chguy t3chguy mentioned this issue Jun 1, 2023
Merged
su-ex added a commit to SchildiChat/element-web that referenced this issue Feb 22, 2024
@su-ex
Merge tag 'v1.11.34' into sc
6d4220e 
* OIDC: add delegatedauthentication to validated server config ([\element-hq#11053](matrix-org/matrix-react-sdk#11053)). Contributed by @kerryarchibald.
* Allow image pasting in plain mode in RTE ([\element-hq#11056](matrix-org/matrix-react-sdk#11056)). Contributed by @alunturner.
* Show room options menu if "UIComponent.roomOptionsMenu" is enabled ([\element-hq#10365](matrix-org/matrix-react-sdk#10365)). Contributed by @maheichyk.
* Allow image pasting in rich text mode in RTE ([\element-hq#11049](matrix-org/matrix-react-sdk#11049)). Contributed by @alunturner.
* Update voice broadcast redaction to use MSC3912 `with_rel_type` instead of `with_relations` ([\element-hq#11014](matrix-org/matrix-react-sdk#11014)). Fixes element-hq#25471.
* Add config to skip widget_build_url for DM rooms ([\element-hq#11044](matrix-org/matrix-react-sdk#11044)). Fixes vector-im/customer-retainer#74.
* Inhibit interactions on forward dialog message previews ([\element-hq#11025](matrix-org/matrix-react-sdk#11025)). Fixes element-hq#23459.
* Removed `DecryptionFailureBar.tsx` ([\element-hq#11027](matrix-org/matrix-react-sdk#11027)). Fixes element-hq/element-meta#1358. Contributed by @florianduros.
* Fix translucent `TextualEvent` on search results panel ([\element-hq#10810](matrix-org/matrix-react-sdk#10810)). Fixes element-hq#25292. Contributed by @luixxiul.
* Matrix matrix scheme permalink constructor not stripping query params ([\element-hq#11060](matrix-org/matrix-react-sdk#11060)). Fixes element-hq#25535.
* Fix: "manually verify by text" does nothing ([\element-hq#11059](matrix-org/matrix-react-sdk#11059)). Fixes element-hq#25375. Contributed by @kerryarchibald.
* Make group calls respect the ICE fallback setting ([\element-hq#11047](matrix-org/matrix-react-sdk#11047)). Fixes vector-im/voip-internal#65.
* Align list items on the tooltip to the start ([\element-hq#11041](matrix-org/matrix-react-sdk#11041)). Fixes element-hq#25355. Contributed by @luixxiul.
* Clear thread panel event permalink when changing rooms ([\element-hq#11024](matrix-org/matrix-react-sdk#11024)). Fixes element-hq#25484.
* Fix spinner placement on pinned widgets being reloaded ([\element-hq#10970](matrix-org/matrix-react-sdk#10970)). Fixes element-hq#25431. Contributed by @luixxiul.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Feb 22, 2024
@su-ex
Merge tag 'v3.74.0' into sc
00748e6 
* OIDC: add delegatedauthentication to validated server config ([\matrix-org#11053](matrix-org#11053)). Contributed by @kerryarchibald.
* Allow image pasting in plain mode in RTE ([\matrix-org#11056](matrix-org#11056)). Contributed by @alunturner.
* Show room options menu if "UIComponent.roomOptionsMenu" is enabled ([\matrix-org#10365](matrix-org#10365)). Contributed by @maheichyk.
* Allow image pasting in rich text mode in RTE ([\matrix-org#11049](matrix-org#11049)). Contributed by @alunturner.
* Update voice broadcast redaction to use MSC3912 `with_rel_type` instead of `with_relations` ([\matrix-org#11014](matrix-org#11014)). Fixes element-hq/element-web#25471.
* Add config to skip widget_build_url for DM rooms ([\matrix-org#11044](matrix-org#11044)). Fixes vector-im/customer-retainer#74.
* Inhibit interactions on forward dialog message previews ([\matrix-org#11025](matrix-org#11025)). Fixes element-hq/element-web#23459.
* Removed `DecryptionFailureBar.tsx` ([\matrix-org#11027](matrix-org#11027)). Fixes element-hq/element-meta#1358. Contributed by @florianduros.
* Fix translucent `TextualEvent` on search results panel ([\matrix-org#10810](matrix-org#10810)). Fixes element-hq/element-web#25292. Contributed by @luixxiul.
* Matrix matrix scheme permalink constructor not stripping query params ([\matrix-org#11060](matrix-org#11060)). Fixes element-hq/element-web#25535.
* Fix: "manually verify by text" does nothing ([\matrix-org#11059](matrix-org#11059)). Fixes element-hq/element-web#25375. Contributed by @kerryarchibald.
* Make group calls respect the ICE fallback setting ([\matrix-org#11047](matrix-org#11047)). Fixes vector-im/voip-internal#65.
* Align list items on the tooltip to the start ([\matrix-org#11041](matrix-org#11041)). Fixes element-hq/element-web#25355. Contributed by @luixxiul.
* Clear thread panel event permalink when changing rooms ([\matrix-org#11024](matrix-org#11024)). Fixes element-hq/element-web#25484.
* Fix spinner placement on pinned widgets being reloaded ([\matrix-org#10970](matrix-org#10970)). Fixes element-hq/element-web#25431. Contributed by @luixxiul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Media A-Message-Forwarding O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inhibit interactions on forward dialog message previews matrix-org/matrix-react-sdk
3 participants
@turt2live @t3chguy @SimonBrandner