Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netlify workflow refers to workflow file that doesn't exist #24071

Closed
dbkr opened this issue Dec 21, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#9826
Closed

Netlify workflow refers to workflow file that doesn't exist #24071

dbkr opened this issue Dec 21, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#9826
Labels
good first issue Good for newcomers Help Wanted Extra attention is needed S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Tasks for the team like planning

Comments

@dbkr
Copy link
Member

dbkr commented Dec 21, 2022 •
edited
Loading

https://github.com/matrix-org/matrix-react-sdk/blob/develop/.github/workflows/netlify.yaml#L38 refers to element-build-and-test.yaml but that file was deleted just over a week after that reference was added (matrix-org/matrix-react-sdk#8677).

I guess it still works fine though...
@dbkr dbkr added T-Defect T-Task Tasks for the team like planning and removed T-Defect labels Dec 21, 2022
@dbkr
Copy link
Member Author

dbkr commented Dec 21, 2022

Oh, it doesn't matter because run_id is specified. The docs allude to not specifying options together although not specifically workflow. Either way, we probably just want to delete workflow.

@t3chguy
Copy link
Member

t3chguy commented Dec 21, 2022

matrix-org/matrix-react-sdk#9649 fixed the same thing in cypress.yaml - just a case of deleting the line

@SimonBrandner SimonBrandner added S-Minor Impairs non-critical functionality or suitable workarounds exist good first issue Good for newcomers labels Dec 22, 2022
@github-actions github-actions bot added the Help Wanted Extra attention is needed label Dec 22, 2022
@t3chguy t3chguy mentioned this issue Dec 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Help Wanted Extra attention is needed S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update netlify.yaml GHA to not refer to workflow name matrix-org/matrix-react-sdk
3 participants
@dbkr @t3chguy @SimonBrandner