This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Update cypress.yaml GHA to not refer to workflow name. #9649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra info: This workflow name doesn't seem to be relevant- the workflow in question hasn't run for ~6months so it seems to be ignoring this value.
t3chguy
approved these changes
Nov 29, 2022
github-actions
bot
added
the
T-Task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More of a nit than a bugfix, that I came across trying to infer how this build worked on a fork.
The previous workflow name is not a reference to a current workflow in the codebase (it was a reference to a previous one). The action still works though, so didn't require the name to be correct.
From https://github.com/dawidd6/action-download-artifact#usage it seems to infer the workflow name from the run_id - so I think we shouldn't pass it to the action so we can avoid confusion.
Example of it running already
Checklist
Type: task
This change is marked as an internal change (Task), so will not be included in the changelog.