Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: We upload a new fallback key on every /sync #25215

Closed
4 tasks done
richvdh opened this issue Apr 26, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3338
Closed
4 tasks done

Element-R: We upload a new fallback key on every /sync #25215

richvdh opened this issue Apr 26, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3338
Assignees
@florianduros
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Apr 26, 2023 •
edited by florianduros
Loading

If we get a /sync request that contains to-device messages or device list changes, then we call receive_sync_changes with an empty unused_fallback_keys, which prompts the olm machine to upload a new fallback key.

The underlying OlmMachine::unused_fallback_keys takes an Option for unused_fallback_keys (and looks like it will not upload a new fallback key if it is set to None). We should update the JS bindings to accept undefined, and pass that instead of the empty set.
@richvdh richvdh added T-Defect A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Apr 26, 2023
@richvdh
Copy link
Member Author

richvdh commented Apr 26, 2023

/cc @florianduros

@florianduros florianduros self-assigned this Apr 27, 2023
This was referenced Apr 27, 2023
Merged
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Dec 13, 2023
@su-ex
Merge tag 'v26.0.0' into sc
54d9823 
* Ensure we do not add relations to the wrong timeline ([\matrix-org#3427](matrix-org#3427)). Fixes element-hq/element-web#25450 and element-hq/element-web#25494.
* Deprecate `QrCodeEvent`, `SasEvent` and `VerificationEvent` ([\matrix-org#3386](matrix-org#3386)).
* Move crypto classes into a separate namespace ([\matrix-org#3385](matrix-org#3385)).
* Mention deno support in the README ([\matrix-org#3417](matrix-org#3417)). Contributed by @sigmaSd.
* Mark room version 10 as safe ([\matrix-org#3425](matrix-org#3425)).
* Prioritise entirely supported flows for UIA ([\matrix-org#3402](matrix-org#3402)).
* Add methods to terminate idb worker ([\matrix-org#3362](matrix-org#3362)).
* Total summary count ([\matrix-org#3351](matrix-org#3351)). Contributed by @toger5.
* Audio concealment ([\matrix-org#3349](matrix-org#3349)). Contributed by @toger5.
* Correctly accumulate sync summaries. ([\matrix-org#3366](matrix-org#3366)). Fixes element-hq/element-web#23345.
* Keep measuring a call feed's volume after a stream replacement ([\matrix-org#3361](matrix-org#3361)). Fixes element-hq/element-call#1051.
* Element-R: Avoid uploading a new fallback key at every `/sync` ([\matrix-org#3338](matrix-org#3338)). Fixes element-hq/element-web#25215.
* Accumulate receipts for the main thread and unthreaded separately ([\matrix-org#3339](matrix-org#3339)). Fixes element-hq/element-web#24629.
* Remove spec non-compliant extended glob format ([\matrix-org#3423](matrix-org#3423)). Fixes element-hq/element-web#25474.
* Fix bug where original event was inserted into timeline instead of the edit event ([\matrix-org#3398](matrix-org#3398)). Contributed by @andybalaam.
* Only add a local receipt if it's after an existing receipt ([\matrix-org#3399](matrix-org#3399)). Contributed by @andybalaam.
* Attempt a potential workaround for stuck notifs ([\matrix-org#3384](matrix-org#3384)). Fixes element-hq/element-web#25406. Contributed by @andybalaam.
* Fix verification bug with `pendingEventOrdering: "chronological"` ([\matrix-org#3382](matrix-org#3382)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florianduros florianduros

Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Element-R: Avoid uploading a new fallback key at every /sync matrix-org/matrix-js-sdk
2 participants
@richvdh @florianduros