Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing reactions for some messages #25596

Closed
Tracked by #24392
MatMaul opened this issue Jun 14, 2023 · 3 comments · Fixed by matrix-org/matrix-js-sdk#3496
Closed
Tracked by #24392

Missing reactions for some messages #25596

MatMaul opened this issue Jun 14, 2023 · 3 comments · Fixed by matrix-org/matrix-js-sdk#3496
Assignees
Labels
A-Reactions O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@MatMaul
Copy link

MatMaul commented Jun 14, 2023

Steps to reproduce

Reactions are fully missing for some messages.

I am going to try a clear cache and report after sending the logs.

impacted message (Element private room):
https://matrix.to/#/!SGNQGPGUwtcPBUotTL:matrix.org/$lHK4qgyCBx362J1cYBk6rMCbNkxZ9UbfCzu0ePL2SnA?via=jki.re&via=matrix.org&via=element.io

Outcome

I should see the reactions but none are present.

This includes one of mine put from the phone (which may be related ? I think the messages was sync on EleWeb after I added the reaction on my phone).

Operating system

Fedora

Application version

1.11.33

How did you install the app?

Flatpak

Homeserver

element.io

Will you send logs?

Yes

@kittykat kittykat added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Reactions O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jun 15, 2023
@Johennes
Copy link
Contributor

I reproduced this issue on this message in the public Element iOS room. Element Android shows a 🎉 reaction on this message. Element Desktop nightly (2023061801) does not show a reaction.

@babolivier
Copy link
Contributor

I've reproduced this issue just now, see #25633 for details and rageshake

@weeman1337
Copy link
Contributor

#25630 (comment) provides some useful information about this.

@t3chguy t3chguy self-assigned this Jun 22, 2023
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Feb 22, 2024
* The Browserify artifact is being deprecated, scheduled for removal in the October 10th release cycle. ([\matrix-org#3189](matrix-org#3189)).
* ElementR: Add `CryptoApi#bootstrapSecretStorage` ([\matrix-org#3483](matrix-org#3483)). Contributed by @florianduros.
* Deprecate `MatrixClient.findVerificationRequestDMInProgress`, `MatrixClient.getVerificationRequestsToDeviceInProgress`, and `MatrixClient.requestVerification`, in favour of methods in `CryptoApi`. ([\matrix-org#3474](matrix-org#3474)).
* Introduce a new `Crypto.VerificationRequest` interface, and deprecate direct access to the old `VerificationRequest` class. Also deprecate some related classes that were exported from `src/crypto/verification/request/VerificationRequest` ([\matrix-org#3449](matrix-org#3449)).
* OIDC: navigate to authorization endpoint ([\matrix-org#3499](matrix-org#3499)). Contributed by @kerryarchibald.
* Support for interactive device verification in Element-R. ([\matrix-org#3505](matrix-org#3505)).
* Support for interactive device verification in Element-R. ([\matrix-org#3508](matrix-org#3508)).
* Support for interactive device verification in Element-R. ([\matrix-org#3490](matrix-org#3490)). Fixes element-hq/element-web#25316.
* Element-R: Store cross signing keys in secret storage ([\matrix-org#3498](matrix-org#3498)). Contributed by @florianduros.
* OIDC: add dynamic client registration util function ([\matrix-org#3481](matrix-org#3481)). Contributed by @kerryarchibald.
* Add getLastUnthreadedReceiptFor utility to Thread delegating to the underlying Room ([\matrix-org#3493](matrix-org#3493)).
* ElementR: Add `rust-crypto#createRecoveryKeyFromPassphrase` implementation ([\matrix-org#3472](matrix-org#3472)). Contributed by @florianduros.
* Aggregate relations regardless of whether event fits into the timeline ([\matrix-org#3496](matrix-org#3496)). Fixes element-hq/element-web#25596.
* Fix bug where switching media caused media in subsequent calls to fail ([\matrix-org#3489](matrix-org#3489)).
* Fix: remove polls from room state on redaction ([\matrix-org#3475](matrix-org#3475)). Fixes element-hq/element-web#25573. Contributed by @kerryarchibald.
* Fix export type `GeneratedSecretStorageKey` ([\matrix-org#3479](matrix-org#3479)). Contributed by @florianduros.
* Close IDB database before deleting it to prevent spurious unexpected close errors ([\matrix-org#3478](matrix-org#3478)). Fixes element-hq/element-web#25597.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reactions O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants