Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Jest test: <JoinRuleSettings /> › Restricted rooms › When room does not support restricted rooms › upgrades room when changing join rule to restricted #25625

Closed
richvdh opened this issue Jun 19, 2023 · 6 comments · Fixed by matrix-org/matrix-react-sdk#11715
Closed

Flaky Jest test: <JoinRuleSettings /> › Restricted rooms › When room does not support restricted rooms › upgrades room when changing join rule to restricted #25625

richvdh opened this issue Jun 19, 2023 · 6 comments · Fixed by matrix-org/matrix-react-sdk#11715
Labels
A-Developer-Experience O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect Z-Flaky-Test A test is raising false alarms

Comments

@richvdh
Copy link
Member

richvdh commented Jun 19, 2023

https://github.com/matrix-org/matrix-react-sdk/actions/runs/5312529645/jobs/9617152858?pr=11110:

  ● <JoinRuleSettings /> › Restricted rooms › When room does not support restricted rooms › upgrades room when changing join rule to restricted

    expect(element).toBeInTheDocument()

    element could not be found in the document

      201 |
      202 |                 // update spaces
    > 203 |                 expect(await screen.findByText("Updating space...")).toBeInTheDocument();
          |                                                                      ^
      204 |
      205 |                 await flushPromises();
      206 |

      at Object.toBeInTheDocument (test/components/views/settings/JoinRuleSettings-test.tsx:203:70)
@richvdh richvdh added T-Defect S-Tolerable Low/no impact on users A-Developer-Experience O-Uncommon Most users are unlikely to come across this or unexpected workflow Z-Flaky-Test A test is raising false alarms labels Jun 19, 2023
@andybalaam andybalaam mentioned this issue Jul 13, 2023
Merged
3 tasks
@andybalaam andybalaam mentioned this issue Sep 5, 2023
Merged
3 tasks
@charlynguyen charlynguyen mentioned this issue Sep 7, 2023
Merged
3 tasks
@richvdh
Copy link
Member Author

richvdh commented Sep 7, 2023

https://github.com/matrix-org/matrix-react-sdk/actions/runs/6115470605/job/16599051674?pr=11529

@andybalaam andybalaam mentioned this issue Sep 8, 2023
Merged
@weeman1337 weeman1337 mentioned this issue Sep 14, 2023
Merged
@andybalaam
Copy link
Contributor

https://github.com/matrix-org/matrix-react-sdk/actions/runs/6234517455/job/16921863815?pr=11612

Technically the test was upgrades room when changing join rule to knock but close enough

@andybalaam
Copy link
Contributor

https://github.com/matrix-org/matrix-react-sdk/actions/runs/6269632562/job/17026351306

@richvdh
Copy link
Member Author

richvdh commented Oct 3, 2023

https://github.com/matrix-org/matrix-react-sdk/actions/runs/6398283093/job/17368078044

@richvdh
Copy link
Member Author

richvdh commented Oct 3, 2023

https://github.com/matrix-org/matrix-react-sdk/actions/runs/6398367336/job/17368361962

@andybalaam
Copy link
Contributor

I can reproduce this locally.

andybalaam added a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 4, 2023
@andybalaam
Don't look for 'Updating space' message in joinrulesettings test
52a8733 
as it may disappear too quickly for us to see.

Fixes element-hq/element-web#25625
@andybalaam andybalaam mentioned this issue Oct 4, 2023
Merged
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 5, 2023
@andybalaam
Unflake JoinRuleSettings test (#11715)
9efa458 
* Don't look for 'Updating space' message in joinrulesettings test

as it may disappear too quickly for us to see.

Fixes element-hq/element-web#25625

* Provide mock function to avoid warning in JoinRuleSettings test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect Z-Flaky-Test A test is raising false alarms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unflake JoinRuleSettings test matrix-org/matrix-react-sdk
2 participants
@andybalaam @richvdh