Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encrypted images mess up scroll position #2624

Closed
richvdh opened this issue Nov 22, 2016 · 3 comments · Fixed by matrix-org/matrix-react-sdk#577
Closed

encrypted images mess up scroll position #2624

richvdh opened this issue Nov 22, 2016 · 3 comments · Fixed by matrix-org/matrix-react-sdk#577
Assignees
@lukebarnard1
Labels
A-E2EE P2 S-Tolerable Low/no impact on users T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Nov 22, 2016

when the image loads, it changes the scroll offset in the window
@richvdh richvdh mentioned this issue Nov 25, 2016
Closed
@ara4n
Copy link
Member

ara4n commented Nov 25, 2016

is this still the case with mark's new iframe-based image loading?

@ara4n ara4n added T-Defect S-Tolerable Low/no impact on users P2 A-E2EE labels Nov 25, 2016
@richvdh
Copy link
Member Author

richvdh commented Nov 25, 2016 via email

@lukebarnard1 lukebarnard1 self-assigned this Dec 2, 2016
lukebarnard1 pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Dec 2, 2016
Fix scroll jump on image decryption
5665a0e 
`onWidgetLoad` is now being called when an image has been decrypted so that the ScrollPanel maintains its scroll position (whether it's stuckAtBottom or not). This attempts to fix element-hq/element-web#2624
@lukebarnard1 lukebarnard1 mentioned this issue Dec 2, 2016
Merged
@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Dec 2, 2016 •
edited
Loading

FTR, this is part of #2646

@lukebarnard1 lukebarnard1 mentioned this issue Dec 2, 2016
Closed
Half-Shot pushed a commit to Half-Shot/matrix-react-sdk that referenced this issue Feb 9, 2017
@Half-Shot
Fix scroll jump on image decryption
9eb5496 
`onWidgetLoad` is now being called when an image has been decrypted so that the ScrollPanel maintains its scroll position (whether it's stuckAtBottom or not). This attempts to fix element-hq/element-web#2624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebarnard1 lukebarnard1

Labels
A-E2EE P2 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix scroll jump on image decryption matrix-org/matrix-react-sdk
3 participants
@ara4n @richvdh @lukebarnard1