Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] Messages sent by a user from 2 differents clients aren't decryptable #2676

Closed
jeangb opened this issue Dec 1, 2016 · 3 comments · Fixed by matrix-org/matrix-ios-sdk#197
Closed

[e2e] Messages sent by a user from 2 differents clients aren't decryptable #2676

jeangb opened this issue Dec 1, 2016 · 3 comments · Fixed by matrix-org/matrix-ios-sdk#197
Labels
A-E2EE P1 T-Defect

Comments

@jeangb
Copy link
Contributor

jeangb commented Dec 1, 2016

To reproduce:

  1. Alice create a room and enable encryption on client 1
  2. Alice sent msg 1.
  3. Alice logs on client 2 while still being on client 1
  4. Alice sent msg 3 on client 2.

msg 3 isn't decryptable on client 1. All the folowing messages sent on a client won't be decryptable on the other client.
@richvdh
Copy link
Member

richvdh commented Dec 1, 2016

yes it seems like we don't download our own device list!

@richvdh richvdh added P1 and removed P2 labels Dec 1, 2016
@manuroe manuroe mentioned this issue Dec 6, 2016
Closed
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Dec 6, 2016
@manuroe
Crypto: Fix Messages sent by a user from 2 different clients aren't d…
cf90faf 
…ecryptable (element-hq/element-web#2676)
@manuroe manuroe mentioned this issue Dec 6, 2016
Merged
@richvdh
Copy link
Member

richvdh commented Dec 6, 2016

Background: when we send the first message from a new client we download device lists for any users we don't already have a cached device list for; but our own device is added directly to the store, rather than being downloaded, which confuses that logic into thinking that we already have a device list for ourselves.

richvdh added a commit to matrix-org/matrix-js-sdk that referenced this issue Dec 6, 2016
@richvdh
E2E: Download our own devicelist on startup
89ced19 
Make sure we get a list of our own devices when starting a new client.

Fixes element-hq/element-web#2676.
@richvdh richvdh mentioned this issue Dec 7, 2016
Merged
@ara4n
Copy link
Member

ara4n commented Dec 7, 2016

RICH DID THIS

@ara4n ara4n closed this as completed Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE P1 T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get user own devices keys matrix-org/matrix-ios-sdk
3 participants
@ara4n @richvdh @jeangb