Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification for unread redacted message in thread gets stuck #26933

Closed
Tracked by #24392
dbkr opened this issue Jan 26, 2024 · 2 comments
Closed
Tracked by #24392

Notification for unread redacted message in thread gets stuck #26933

dbkr opened this issue Jan 26, 2024 · 2 comments
Labels
A-Notifications A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@dbkr
Copy link
Member

dbkr commented Jan 26, 2024

Steps to reproduce

  1. Get 2 clients.
  2. From one client, create room, post message.
  3. Read that event in the other client, then click off the room
  4. Post another message creating a thread from that message. Make sure it's a message that notifis the other client.
  5. In the same client that posted it (without viewing it the other), redact that message.
  6. Observe you now have a notification with no matching message in the other client, so no way to clear it.
  7. Clear cache & reload in the client with the stuck notif, observe that you still have a stuck notif.

Outcome

What did you expect?

Redacting a message in the main timeline causes the notification to vanish, so probably that, although getting notifications that can then disappear without a trace seems problematic.

What happened instead?

Stuck notif with no obvious cause & no way to clear.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@florianduros
Copy link
Member

Unable to reproduce it. Maybe fix by matrix-org/matrix-js-sdk#4022?

@florianduros florianduros added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Threads labels Jan 29, 2024
@dbkr
Copy link
Member Author

dbkr commented Jan 29, 2024

Just retested before and after pulling latest js-sdk and indeed, I could repro it before but not after, so I'm going to say this is fixed!

@dbkr dbkr closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants