-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make timeline
a getter
#4022
Merged
Merged
Make timeline
a getter
#4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but definitely needs testing before merging.
3 tasks
florianduros
force-pushed
the
florianduros/unread/timeline-proxy
branch
from
January 23, 2024 13:59
1f8fd8a
to
67eb3a0
Compare
This fixes my bug with Threads being marked permanently as unread, despite being read (they'd revert to unread after restart). Now I can actually mark all the threads as read (if I don't care about them) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
When looking for stuck unreads, we noticed sometimes that
timeline
andthis.getLiveTimeline().getEvents()
are different.timeline
is a copy ofthis.getLiveTimeline().getEvents()
which is manually updated. To avoid missing copy,timeline
becomes a getter ofthis.getLiveTimeline().getEvents()
.Also make
timeline
deprecated.After some days of testing it, it seems to get rid of the remaining stuck unreads and make disappear some of the zombie notifications.
Closes element-hq/element-web#26878
Part of element-hq/element-web#24392
Notes: Fix cases of stuck unreads and zombie notifications (comes back after a refresh)
Here's what your changelog entry will look like:
🐛 Bug Fixes
hasUserReadEvent event ID X not found in room Y: this shouldn't happen!
element-hq/element-web#26878. Contributed by @florianduros.