Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTD messages sent before migration to Rust Crypto are incorrectly shown as Expected UTDs #27590

Closed
richvdh opened this issue Jun 17, 2024 · 3 comments · Fixed by matrix-org/matrix-rust-sdk-crypto-wasm#128 or matrix-org/matrix-js-sdk#4261
Assignees
Labels
A-E2EE A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-UISI Unable to decrypt errors

Comments

@richvdh
Copy link
Member

richvdh commented Jun 17, 2024

If you receive a message which you cannot decrypt, using the legacy crypto stack, it is shown as a regular "Unable to Decrypt" event.

Then, if you are migrated to Rust crypto, the same message is incorrectly treated as an Expected UTD, with the error message:

"DecryptionError: This message was sent before this device logged in."

(Note that you don't actually have to have seen the event on legacy crypto to hit the bug: the point is that you must have been migrated to Rust crypto after the message was sent. The migrated session is incorrectly treated as being "new".)

@richvdh richvdh added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist Z-UISI Unable to decrypt errors O-Occasional Affects or can be seen by some users regularly or most users rarely A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Jun 17, 2024
@dosubot dosubot bot added A-E2EE S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jun 17, 2024
@t3chguy
Copy link
Member

t3chguy commented Jun 17, 2024

@richvdh should this be a blocker to any further migration?

@richvdh
Copy link
Member Author

richvdh commented Jun 18, 2024

Probably. matrix-org/matrix-rust-sdk-crypto-wasm#128 should fix it.

@richvdh richvdh removed the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label Jun 18, 2024
@richvdh richvdh reopened this Jun 18, 2024
@richvdh
Copy link
Member Author

richvdh commented Jun 18, 2024

Reopening until the fix lands in EW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-UISI Unable to decrypt errors
Projects
None yet
2 participants