Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgot password reset UX is a total cluster #2780

Closed
ara4n opened this issue Dec 21, 2016 · 20 comments
Closed

Forgot password reset UX is a total cluster #2780

ara4n opened this issue Dec 21, 2016 · 20 comments
Labels
A-Password-Reset O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Needs-Design X-Needs-Info This issue is blocked awaiting information from the reporter Z-Chronic

Comments

@ara4n
Copy link
Member

ara4n commented Dec 21, 2016

it doesn't tell you if you have no email address linked (or warn you sensibly), and it makes you enter your new password before you've confirmed you can do anything at all.

@ara4n ara4n added the S-Critical Prevents work, causes data loss and/or has no workaround label Jul 13, 2017
@ara4n
Copy link
Member Author

ara4n commented Jul 13, 2017

Just been talking to folks about disasters where they lost 30% of a 10,000 userbase due to inability to do a password reset......

@ara4n
Copy link
Member Author

ara4n commented Jan 19, 2018

@dbkr can we mitigate this nowadays by using the tokenRequest APIs to do sanity checks before you enter the new PW?

@dbkr
Copy link
Member

dbkr commented Jan 24, 2018

Yeah, I don't see why not. We probably ought to check what auth is acceptable for a password reset (eg. if we want to support pw rest via sms too) but that's fine as we can do a call with no auth first like we do for registering.

@turt2live
Copy link
Member

This is still a problem.

@lampholder lampholder removed the design label Feb 27, 2019
@lampholder
Copy link
Member

A motivated user failed to reset their password ~5 times, it seems due to closing the tab before clicking the button you're meant to click after clicking the link in the email.

We really need a password reset flow that works like everybody else's password reset flow - it's the kind of operation people expect to complete on autopilot.

@ara4n
Copy link
Member Author

ara4n commented Apr 4, 2019

see also #2761

@ara4n
Copy link
Member Author

ara4n commented May 2, 2019

Here's another one:

Screenshot 2019-05-02 at 20 38 27

@lampholder
Copy link
Member

In addressing this issue we should review https://github.com/vector-im/riot-web/labels/type%3Apassword-reset too

@richvdh
Copy link
Member

richvdh commented May 10, 2019

see alo matrix-org/synapse#1710

@lampholder
Copy link
Member

I've taken the 'burning fire' label off this so that we can queue it up as a roadmap item rather than try and handle it as an urgent production issue.

I've added it to the NEXT column of our roadmap

@Flexmaen
Copy link

Flexmaen commented May 15, 2020

This is also confusing. When trying to get a mail to reset your old unknown password, Riot will promt you for a password.
The whole process is very confusing, why can't this be done like everywhere else?

riot_passwort

@jryans jryans removed the Z-UI/UX label Mar 9, 2021
@novocaine novocaine added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Aug 4, 2021
@niquewoodhouse niquewoodhouse removed their assignment Aug 23, 2021
@novocaine novocaine added the X-Needs-Info This issue is blocked awaiting information from the reporter label Aug 25, 2021
@novocaine novocaine changed the title password reset UX is a total cluster Forgot password reset UX is a total cluster Aug 25, 2021
@novocaine
Copy link
Contributor

novocaine commented Aug 25, 2021

I am splitting this issue into multiple actionable ones as, while we need to fix stuff, it is not currently actionable and the labels seem off.

Assumption: This ticket relates to "forgot password" specifically, not password reset.

Issues named in this one:

  1. It doesn't tell you if you have no email address linked (or warn you sensibly)

I'm not sure if this is still relevant but I might misunderstand the meaning. In the current UI you can't reset your password without entering an email - this might have been changed at some point. Need @ara4n to confirm.

Screenshot 2021-08-25 at 14 39 40

  1. and it makes you enter your new password before you've confirmed you can do anything at all

This is confusing. On other web sites you enter a new password after verifying your email, not before. Split into element-hq/element-meta#359.

@novocaine
Copy link
Contributor

novocaine commented Aug 25, 2021

Closing this mega-ticket in favour of the spun out tickets created above. Yell if I have not captured a part of this in those tickets.

@ara4n
Copy link
Member Author

ara4n commented Aug 25, 2021

In the current UI you can't reset your password without entering an email - this might have been changed at some point. Need @ara4n to confirm.

From memory, the problem is that it gives you no indication if the email you provided is remotely valid or known. This might be a privacy measure, but the fact you have no idea which email address it’s asking you for and if you got the right one is still a problem afaik.

@novocaine
Copy link
Contributor

In the current UI you can't reset your password without entering an email - this might have been changed at some point. Need @ara4n to confirm.

From memory, the problem is that it gives you no indication if the email you provided is remotely valid or known. This might be a privacy measure, but the fact you have no idea which email address it’s asking you for and if you got the right one is still a problem afaik.

Yep, my understanding is most sites provide no feedback for this to prevent email discovery for privacy reasons but also to stop automated brute-forcers using it as step 1.

Happy to create an enhancement ticket if you have any ideas..

@ara4n
Copy link
Member Author

ara4n commented Aug 25, 2021

i think it would be good enough to just be explicit to the user that the email may or may not be correct, rather than leaving them guessing on what’s going on (or not)

@novocaine
Copy link
Contributor

So we should validate if the email address is in our database or not, and if it isn't, show an error message to the user?

@novocaine
Copy link
Contributor

Clarified out of band that we just want a copy change.

@novocaine
Copy link
Contributor

Just checked this, and the current behaviour is that we show an error message if the email isn't recognised (at least on matrix.org)

Screenshot 2021-09-01 at 11 20 48

This is triggered by a call to https://matrix-client.matrix.org/_matrix/client/r0/account/password/email/requestToken 400ing and returning {"errcode":"M_THREEPID_NOT_FOUND","error":"Email not found"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Password-Reset O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Needs-Design X-Needs-Info This issue is blocked awaiting information from the reporter Z-Chronic
Projects
None yet
Development

No branches or pull requests