Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexeddb only persists history ~5 minutes after initial sync completes #3527

Closed
ara4n opened this issue Mar 28, 2017 · 3 comments
Closed

Indexeddb only persists history ~5 minutes after initial sync completes #3527

ara4n opened this issue Mar 28, 2017 · 3 comments
Assignees
@dbkr
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Milestone
RW002

Comments

@ara4n
Copy link
Member

ara4n commented Mar 28, 2017

I launched riot.im/develop for the first time on a new session. I waited forever for the initial sync to complete. I then refreshed the page after a few minutes of use. It resynced from scratch all over again. Surely the second our initial sync completes we should be persisting it to indexeddb?
@lampholder lampholder added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 labels Mar 28, 2017
@lampholder
Copy link
Member

MAJOR because it sounds like we're not reaping the full benefit of the indexdb in this particular case.

Assigning to @dbkr to consider along with the other bits he's looking at for the next riot web release; I think this might turn out to be release-blocking, though that depends on the specifics around it.

@lampholder lampholder added this to the RW002 milestone Apr 3, 2017
@lampholder
Copy link
Member

@dbkr did you manage to look at this alongside the other indexdb stuff you were looking at?

@lampholder
Copy link
Member

Let's make it so it saves after the first sync.

dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Apr 6, 2017
@dbkr
Make indexeddb save after the first sync
b53318e 
Save the sync data to indexeddb after the first catch-up

Fixes element-hq/element-web#3527
@dbkr dbkr closed this as completed Apr 6, 2017
@dbkr dbkr mentioned this issue Apr 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
RW002
Development

No branches or pull requests
3 participants
@dbkr @ara4n @lampholder