Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to configure 'enter' to insert line break rather than send message #5006

Closed
richvdh opened this issue Sep 8, 2017 · 21 comments · Fixed by matrix-org/matrix-react-sdk#5160

Comments

@richvdh
Copy link
Member

richvdh commented Sep 8, 2017

Apparently telegram lets you do this and some people prefer it ¯\(ツ)

@poulad
Copy link

poulad commented Sep 8, 2017

See #5005

@lampholder
Copy link
Member

gitter also has a 'compose mode' (or something like that) which consumes Enter as line break rather than send message.

Closing this one, though, 'cause it does look like a dup of #5005

@t3chguy
Copy link
Member

t3chguy commented Sep 8, 2017

@lampholder it is a dup of 5005, which has been already closed

@t3chguy t3chguy reopened this Sep 8, 2017
@poulad
Copy link

poulad commented Sep 8, 2017

There was no need for this in the first place. #5005 could be reopened.

@poulad
Copy link

poulad commented Sep 8, 2017

Why people rushing to open or close issues before even understanding what the issue was about?!

@t3chguy
Copy link
Member

t3chguy commented Sep 8, 2017

The title of this issue is more apt than that of 5005, easier to reopen than reopen and twiddle a title.

@richvdh richvdh removed the duplicate label Sep 8, 2017
@lampholder lampholder added the P3 label Sep 11, 2017
@MacLemon
Copy link
Contributor

Semantically correct would be to use Return (⏎) to create a new line and Enter (⌅) to submit the message. Since way too many people don't understand the significant difference between these keys, or have no idea that their laptop keyboard actually does have these keys absurd solutions come up.

My suggestion:
Insert a line break: Return (⏎)
Submit a message: Enter (⌅) or Control-Return (⌃⏎) (For keyboards lacking a real Enter key (which are pretty much none) and for people not knowing that their key indeed does have an Enter key (which are surprisingly common).)

@poulad
Copy link

poulad commented Sep 12, 2017

@MacLemon Both Return (⏎) and Enter (⌅) on a PC keyboard? Where?!

@MacLemon
Copy link
Contributor

I expect anyone to know where the return key is. Enter is either on your number-pad to the far right or by pressing fn-return if you have a small keyboard. Many people also remap a spare key to be an enter key.

@pafcu
Copy link
Contributor

pafcu commented Oct 10, 2017

@MacLemon The very common keyboard I have in front of me label both keys "Enter".

@MacLemon
Copy link
Contributor

@pafcu Ouch

@poulad
Copy link

poulad commented Oct 12, 2017

@pafcu Same here

@quicktrick
Copy link

Riot for Windows (I haven't found its repository, sorry)

I vote for this feature too (Enter to make a new line, Ctlr+Enter to send). It's a must! Please, make it as soon as possible! Thank you in advance!

@t3chguy
Copy link
Member

t3chguy commented Jun 14, 2018

PR in the works for this, made for after-switch-to-SlateJS

@t3chguy
Copy link
Member

t3chguy commented Jun 17, 2019

@tanriol
Copy link

tanriol commented Dec 22, 2019

What's the way forward to having this option? Should matrix-org/matrix-react-sdk#1966 be updated or is this waiting for the universal keybinding UI?

@t3chguy
Copy link
Member

t3chguy commented Dec 22, 2019

image
Slack has the above as the configuration option for this which is even more vague, if ticked you need to Ctrl+Enter to send

@aybiss
Copy link

aybiss commented May 7, 2020

Me too!

@fulljackz
Copy link

Must have !

@PapaV

This comment has been minimized.

@aybiss
Copy link

aybiss commented Nov 20, 2020

Somebody screenshot this before the DD by people who don't know what a return key is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

13 participants