configurable Enter behaviour for ComposerInput #1966
Conversation
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
| @@ -99,6 +99,11 @@ export const SETTINGS = { | |||
| displayName: _td('Disable Emoji suggestions while typing'), | |||
| default: false, | |||
| }, | |||
| "MessageComposerInput.enterSends": { | |||
| supportedLevels: LEVELS_ACCOUNT_SETTINGS, | |||
| displayName: _td('Use Enter to send message'), | |||
There was a problem hiding this comment.
This label doesn't explain what happens if this were to be unchecked (false).
There was a problem hiding this comment.
Got any better suggestions with wording? :(
There was a problem hiding this comment.
Well, I don't think it can be mapped to a boolean flag. This seems to fall squarely into keybinding territory.
There was a problem hiding this comment.
Well the intent is to only offer a toggle of:
There was a problem hiding this comment.
which is what other chat apps give you
There was a problem hiding this comment.
I'd still personally vote for a keybinding UI of some kind given the wide range things that also need keybindings.
Although if you're dead set on the boolean: Maybe have the wording be "Use Enter to send messages, otherwise CTRL+Enter"?
|
@myii its currently unknown whether this is the desired approach versus a
|
|
Thanks for making this contribution a while back. Since the code base has changed since this was opened, it no longer applies cleanly, and I don't think there's a need to keep it open in this state, as we can always find the code here again if needed. If you are still interested in pursuing this feature, please discuss with us in #riot-dev:matrix.org to find a good approach forward. |
Fixes element-hq/element-web#5006
Blocked on #1890not yet i18n'd
allows users to choose Enter functionality