Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on LeftPanel when in any settings page should exit settings #5658

Closed
ara4n opened this issue Nov 20, 2017 · 3 comments · Fixed by matrix-org/matrix-react-sdk#2096
Closed

Clicking on LeftPanel when in any settings page should exit settings #5658

ara4n opened this issue Nov 20, 2017 · 3 comments · Fixed by matrix-org/matrix-react-sdk#2096
Assignees
@dbkr
Labels
P1 T-Defect X-Regression
Milestone
RW010

Comments

@ara4n
Copy link
Member

ara4n commented Nov 20, 2017

Rather than forcing the user to go hunt for the (X) button
@ara4n ara4n changed the title Clicking on LeftPanel when in any settings page should exist settings Clicking on LeftPanel when in any settings page should exit settings Nov 20, 2017
@t3chguy
Copy link
Member

t3chguy commented Nov 20, 2017

This used to be the case, back when the faded sidebars where click-through-able
So is a regression :P

@lukebarnard1
Copy link
Contributor

oh.

The faded UI is disabled with CSS pointer-events: none.

Instead, we could have a store that controls whether the left/right panels are disabled and then not do things when the UI is disabled.

@t3chguy t3chguy mentioned this issue Dec 4, 2017
Closed
@ara4n ara4n added the S-Tolerable Low/no impact on users label Feb 12, 2018
@lampholder
Copy link
Member

For clarity, the desired behaviour is for a click on the faded room list or llp ("outside of the modal") should close settings ("dismiss the modal").

So the first click outside of the settings pane will dismiss settings, but the click will not pass through to the underlying element.

@lampholder lampholder added this to the 0.15 - candidates milestone Mar 26, 2018
@lampholder lampholder removed the S-Tolerable Low/no impact on users label Mar 26, 2018
@lampholder lampholder modified the milestones: RW007, RW008 - Candidates Apr 30, 2018
@lampholder lampholder modified the milestones: RW008, RW010 - Candidates Jun 10, 2018
@dbkr dbkr self-assigned this Jul 26, 2018
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 26, 2018
@dbkr
Make clicking on side panels close settings
54170c7 
By wrapping them in another div and only disabling pointer events
on the inner div.

Fixes element-hq/element-web#5658
@dbkr dbkr mentioned this issue Jul 26, 2018
Closed
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 27, 2018
@dbkr
Make clicking on side panels close settings (mk 2)
511e6f5 
Capture the clicks in LoggedInView and dismiss the settings view,
then discard the click event. Remove `pointer-events: none`
so we can capture the click.

Fixes element-hq/element-web#5658
@dbkr dbkr mentioned this issue Jul 27, 2018
Closed
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 27, 2018
@dbkr
Make clicking on side panels close settings (mk 3)
e059a08 
Just do it by fixing the somewhat hacky logic to not break if the
target elements also have additional classes, like they do if the
toolbar is showing (I think it turns out this bug is only that it
doesn't work with the toolbar showing...)

Fixes element-hq/element-web#5658
@dbkr dbkr mentioned this issue Jul 27, 2018
Merged
@t3chguy t3chguy closed this as completed Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
P1 T-Defect X-Regression
Projects
None yet
Milestone
RW010
Development

Successfully merging a pull request may close this issue.

Make clicking on side panels close settings (mk 3) matrix-org/matrix-react-sdk
5 participants
@dbkr @ara4n @lampholder @t3chguy @lukebarnard1