Homogenise all mentions of Groups to Communities (including error messages)

[AmandineLP]

some error messages still mention Group rather than Community

[lampholder]

As @t3chguy says matrix-org/matrix-react-sdk#1714 fixes some instances of this but possibly not all.

[lukebarnard1]

A scan of the code reveals no remaining instances of the word "group" in the text, at least where it should be "community". Any remaining ones will be error messages that we pass thru from Synapse.

[ara4n]

From a quick inspection:

Matthews-MacBook-Pro:synapse matthew$ grep -ri 'group' . | fgrep \" | grep -i error | fgrep .py:
./groups/groups_server.py:            raise SynapseError(400, "Group not on this server")
./groups/groups_server.py:            raise SynapseError(404, "Unknown group")
./groups/groups_server.py:            raise SynapseError(404, "Unknown group")
./groups/groups_server.py:                raise SynapseError(403, "User is not admin in group")
./groups/groups_server.py:            raise SynapseError(404, "Unknown group")
./groups/groups_server.py:            raise SynapseError(403, "User not in group")
./groups/groups_server.py:            raise SynapseError(403, "User not invited to group")
./groups/groups_server.py:            raise SynapseError(403, "Group is not publicly joinable")
./groups/groups_server.py:                raise SynapseError(403, "User is not admin in group")
./groups/groups_server.py:            raise SynapseError(400, "Group already exists")
./groups/attestations.py:            raise SynapseError(400, "Attestation has incorrect group_id")
./groups/attestations.py:            raise SynapseError(400, "Neither user not group are on this server")
./storage/group_server.py:            raise SynapseError(400, "room not in group")
./storage/group_server.py:            raise SynapseError(400, "user not in group")
./federation/transport/server.py:            raise SynapseError(403, "group_id doesn't match origin")

[lampholder]

We also leak the 'group' word in the riot url:

http://riot.im/app/#/group/+example_community_zappa:matrix.org

[ara4n]

The right solution here is surely for synapse to return proper error codes for all of these different scenarios which can then be i18nized correctly on clients. It doesn't feel like a bug that at the API level and synapse impl level we systematically call them groups though, just as long as that doesn't leak to the user.

[SimonBrandner]

Spaces are now in beta