Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message is not cleared after fixing it #6004

Closed
AmandineLP opened this issue Jan 18, 2018 · 4 comments
Closed

Error message is not cleared after fixing it #6004

AmandineLP opened this issue Jan 18, 2018 · 4 comments
Labels
A-Spaces Spaces, groups, communities Help Wanted Extra attention is needed P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Tolerable Low/no impact on users T-Defect

Comments

@AmandineLP
Copy link
Contributor

AmandineLP commented Jan 18, 2018 •
edited
Loading

When creating a Community, if the first time I leave the community ID field empty and the second time I make an error filling it up, the error message about the empty field is still displayed
image

Steps to reproduce

  • click on + to create a new community
  • give it a name
  • leave the ID empty
  • press enter
    => error msg about empty ID
  • fill the ID with an error (eg by using a capital)
  • press enter
    => the error msg about the empty field is still displayed
@t3chguy
Copy link
Member

t3chguy commented Jan 20, 2018

The Group ID cannot be empty check should be done locally so that it can be i18n'd, but this does highlight another issue yet.

The fact it says Group ID is a Synapse bug

@t3chguy t3chguy mentioned this issue Jan 20, 2018
Merged
@lampholder
Copy link
Member

Hopefully we get an error code from Synapse - we could also use this (in theory at least) to provide i18n-proof errror messages (I don't know how easy this actually is to implement with the rest of the i18n stuff).

@lampholder
Copy link
Member

Related (almost dup): #6003

@lampholder lampholder added T-Defect ui/ux P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Tolerable Low/no impact on users A-Spaces Spaces, groups, communities Help Wanted Extra attention is needed and removed archive labels Jan 22, 2018
@t3chguy
Copy link
Member

t3chguy commented Jan 22, 2018

.oO (if only all the ERRCODEs were spec'd so they were a thing we could actually reply one esp for things like groups)

@t3chguy t3chguy closed this as completed Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Spaces Spaces, groups, communities Help Wanted Extra attention is needed P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lampholder @t3chguy @AmandineLP