Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign: timeline: implement new file transfer UX #7565

Closed
1 of 6 tasks
bwindels opened this issue Oct 25, 2018 · 2 comments
Closed
1 of 6 tasks

Redesign: timeline: implement new file transfer UX #7565

bwindels opened this issue Oct 25, 2018 · 2 comments
Assignees
@dbkr
Labels
A-File-Upload Attachments and file uploads T-Enhancement

Comments

@bwindels
Copy link
Contributor

bwindels commented Oct 25, 2018 •
edited by dbkr
Loading

Questions:

  • do we have design for multiple images? What if images and other files are mixed? Revert to just showing as file icons?
@bwindels bwindels mentioned this issue Oct 26, 2018
Closed
@turt2live turt2live mentioned this issue Dec 4, 2018
Open
@lampholder lampholder added the A-File-Upload Attachments and file uploads label Mar 11, 2019
@lampholder lampholder mentioned this issue Mar 14, 2019
Closed
@dbkr dbkr self-assigned this Mar 28, 2019
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 1, 2019
@dbkr
Implement redesigned upload confirmation screens
5b2cee2 
Also fairly significant refactor of the uploading code: there are
a number of different ways of triggerring a file upload and each
went through a different code path (the media config size limit
worked on one of those paths). Basically take a lot of code out
of the views and put it into ContentMessages.

Sorry about the size of this patch.

element-hq/element-web#7565
@dbkr dbkr mentioned this issue Apr 1, 2019
Merged
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 9, 2019
@dbkr
Apply design to image thumbnails
b1c2108 
Border & rounded corners

element-hq/element-web#7565
@dbkr dbkr mentioned this issue Apr 9, 2019
Closed
@MurzNN
Copy link
Contributor

MurzNN commented Jun 15, 2020

do we have design for multiple images?

At now Matrix don't allow attaching multiple images to single m.room.message event, only sending each image as separate m.image event (without text). For right implementation will be good to extend m.room.message via message attachments, here is my feature request about this: https://github.com/matrix-org/matrix-doc/issues/2289

@MurzNN MurzNN mentioned this issue Nov 27, 2020
Open
@MurzNN MurzNN mentioned this issue Sep 7, 2021
Open
@turt2live
Copy link
Member

We've since modified the appearance here. If there's further work to be done, we can track it with new issues. If people have suggestions for such UX, please open new feature requests for consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
A-File-Upload Attachments and file uploads T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bwindels @jryans @MurzNN @dbkr @turt2live @lampholder