Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add safety around event lookups in settings #8530

Closed
turt2live opened this issue Feb 11, 2019 · 2 comments
Closed

Add safety around event lookups in settings #8530

turt2live opened this issue Feb 11, 2019 · 2 comments
Assignees
@turt2live
Labels
A-Room-Settings

Comments

@turt2live
Copy link
Member

They might not exist, so don't try to call .getContent on them.
@turt2live
Copy link
Member Author

There's other places we might want to consider too: #6635

@turt2live turt2live self-assigned this Feb 11, 2019
@tulir tulir mentioned this issue Feb 14, 2019
Closed
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 14, 2019
@turt2live
Add a bit of safety around reading events for room settings
f46df2d 
Fixes element-hq/element-web#8530 and maybe element-hq/element-web#8641
@turt2live turt2live mentioned this issue Feb 14, 2019
Merged
@turt2live
Copy link
Member Author

Fixed by matrix-org/matrix-react-sdk#2648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Room-Settings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turt2live