Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save button gives zero UI feedback when adding/removing aliases in RoomSettings #8783

Closed
ara4n opened this issue Feb 19, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#2679
Closed

Save button gives zero UI feedback when adding/removing aliases in RoomSettings #8783

ara4n opened this issue Feb 19, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#2679
Assignees
@turt2live

Comments

@ara4n
Copy link
Member

ara4n commented Feb 19, 2019

There's no spinner, and the Save button doesn't transition to green->grey to show that stuff has been saved. This is basically the same as #8581, and related to #8569 but i'd prefer we tracked it as a first class bug as it's really really bad UX.
@turt2live
Copy link
Member

This is also duplicate of several other issues with aliases. The component needs work as a whole because it doesn't match the theme at all.

The save button is intended to disappear.

@turt2live turt2live self-assigned this Feb 19, 2019
This was referenced Feb 19, 2019
Closed
Merged
@turt2live
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#2679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix AliasSettings and RelatedGroups UX matrix-org/matrix-react-sdk
2 participants
@turt2live @ara4n