Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After setting displayname in User Settings and hitting Save, the Save button ungreys itself #8569

Closed
ara4n opened this issue Feb 13, 2019 · 3 comments
Closed

After setting displayname in User Settings and hitting Save, the Save button ungreys itself #8569

ara4n opened this issue Feb 13, 2019 · 3 comments
Assignees
@turt2live
Labels
A-User-Settings P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Feb 13, 2019

Save button should stay grey after you hit save, as there are no more changes to be saved, but it does not...
@turt2live turt2live mentioned this issue Feb 13, 2019
Closed
@turt2live
Copy link
Member

This is intentional design on my part fwiw. There's not really a reasonable way for the user to realize that the values have been successfully committed, so it re-enables the button as a visual cue.

@turt2live turt2live mentioned this issue Feb 13, 2019
Closed
@lampholder
Copy link
Member

I'm with Matthew on this one - the message I receive from the save button going green again is that my changes weren't persisted.

@lampholder lampholder added T-Defect A-User-Settings P1 S-Minor Impairs non-critical functionality or suitable workarounds exist labels Feb 19, 2019
@ara4n ara4n mentioned this issue Feb 19, 2019
Closed
This was referenced Feb 19, 2019
Closed
Closed
@turt2live turt2live self-assigned this Mar 1, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 1, 2019
@turt2live
Don't re-enable the save button after saving profiles
b84b11d 
Fixes element-hq/element-web#8569
@turt2live turt2live mentioned this issue Mar 1, 2019
Merged
@turt2live
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#2726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-User-Settings P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @ara4n @lampholder