Regression when hitting enter to submit when uploading files.

[ara4n]

We have a really weird annoying regression that appeared about 3-4 months ago which I hoped would magically disappear but hasn't: when I click the upload button to upload files in a room, it brings up the file selector dialog. if i immediately hit enter to select the file i want to send, it cancels the dialog(?)... and then unexpectedly brings up the file open dialog again. it's as if the focus is still stuck on the upload button when I hit enter, and it's very annoying.

This is on latest Chrome on macOS Mojave. I assume the solution is probably to explicitly defocus the upload button as soon as it's pressed or something stupid.

[turt2live]

Can't reproduce on Chrome/Windows 10. It all seems to behave for me (even returning focus to the composer when it is all said and done, which is something I expected to be a bug)

[ara4n]

n.b. you have to immediatly hit enter to select the file to be sent, and it's quite hard to repo on macOS too. honestly, i wonder if what's happening is that there's a race between hitting enter to select the first thing in the dialog and the dialog even appearing. Which makes sense, as I know the dialog will default to the most recent thing on my desktop, which will typically be the file i want to upload (e.g. a screenshot).

the soln is still going to be to explicitly defocus the upload button as soon as it's clicked, i think, so that if you then immediately hit enter, it doesn't go and click said button again.

[turt2live]

ah, I can repro it if I mash the enter button twice to select a file. The race does sound like the right thing that is happening.

[lampholder]

Huh, I can't repro this at all on firefox or chrome on mojave.

Nothing seems to be automatically-selected on my file picker - not the most recent file on the desktop (even if I don't try mashing any buttons quickly to reproduce this error) or the cancel button.

[lampholder]

@ara4n I've P2 Minor'ed this since it doesn't feel like something that's going to be affecting a lot of people, but do feel free to bump it up.

[ara4n]

i get bitten by this roughly every time I upload a file; it looks like this:

upload.bug.mov

The sequence is:

• Hit the upload button
• Immediately press the down-arrow key to select the most recent file (e.g. a screenshot you're sending from your desktop; the typical case for me)
• Immediately press return to send that file
• Return doesn't send the file though; instead it reopens the upload prompt. If you're lucky it might also try to send the original file too.
• Find yourself in the upload dialog again; reselect the file; this time i'll work (but if you cancel it, it might still be trying to send the first file).

I think the fix is to debounce the file upload button, so the second the user presses the button, disable it for 500ms or whatever.