Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Third party invites not transferred on upgrade #9115

Closed
turt2live opened this issue Mar 11, 2019 · 4 comments
Closed

Third party invites not transferred on upgrade #9115

turt2live opened this issue Mar 11, 2019 · 4 comments
Labels
A-Invite A-Room-Upgrades P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Won't-Fix

Comments

@turt2live
Copy link
Member

It's extremely questionable how this is handled - should a new invite be issued? Is the IS involved? Do we need to spec it?
@turt2live turt2live added T-Defect P1 S-Minor Impairs non-critical functionality or suitable workarounds exist A-Invite A-Room-Upgrades labels Mar 14, 2019
@turt2live
Copy link
Member Author

@lampholder do you have thoughts on this one? I'm not entirely sure if we should bother transferring these invites given we don't transfer other invites/membership. Does it seem unreasonable to expect someone to re-send an invite post-upgrade?

@lampholder
Copy link
Member

IIUC we don't transfer membership, and we don't transfer regular invites, so I think it would be very confusing and inconsistent (not to mention complicated) if we did transfer 3pid invites.

The UX shouldn't even be too bad for users who eventually do claim their outstanding 3pid invites. Tombtone events are state events, so if:

  1. you're invited to a room
  2. that room is upgraded
  3. you accept your invite

You should still see that tombstone event and be able to follow the trail to where you want to be.

@turt2live
Copy link
Member Author

I'm going to close this as wontfix then, leaving one of the other issues for tracking invites to sort the general problem out.

@lampholder

This comment has been minimized.

Sign in to view
su-ex added a commit to SchildiChat/element-web that referenced this issue Aug 22, 2022
@su-ex
Merge tag 'v1.11.3' into sc
d397360 
* Improve auth aria attributes and semantics ([\element-hq#22948](element-hq#22948)).
* Device manager - New device tile info design ([\element-hq#9122](matrix-org/matrix-react-sdk#9122)). Contributed by @kerryarchibald.
* Device manager generic settings subsection component ([\element-hq#9147](matrix-org/matrix-react-sdk#9147)). Contributed by @kerryarchibald.
* Migrate the hidden read receipts flag to new "send read receipts" option ([\element-hq#9141](matrix-org/matrix-react-sdk#9141)).
* Live location sharing - share location at most every 5 seconds ([\element-hq#9148](matrix-org/matrix-react-sdk#9148)). Contributed by @kerryarchibald.
* Increase max length of voice messages to 15m ([\element-hq#9133](matrix-org/matrix-react-sdk#9133)). Fixes element-hq#18620.
* Move pin drop out of labs ([\element-hq#9135](matrix-org/matrix-react-sdk#9135)).
* Start DM on first message ([\element-hq#8612](matrix-org/matrix-react-sdk#8612)). Fixes element-hq#14736.
* Remove "Add Space" button from RoomListHeader when user cannot create spaces ([\element-hq#9129](matrix-org/matrix-react-sdk#9129)).
* The Welcome Home Screen: Dedicated Download Apps Dialog ([\element-hq#9120](matrix-org/matrix-react-sdk#9120)). Fixes element-hq#22921. Contributed by @justjanne.
* The Welcome Home Screen: "Submit Feedback" pane ([\element-hq#9090](matrix-org/matrix-react-sdk#9090)). Fixes element-hq#22918. Contributed by @justjanne.
* New User Onboarding Task List ([\element-hq#9083](matrix-org/matrix-react-sdk#9083)). Fixes element-hq#22919. Contributed by @justjanne.
* Add support for disabling spell checking ([\element-hq#8604](matrix-org/matrix-react-sdk#8604)). Fixes element-hq#21901.
* Live location share - leave maximised map open when beacons expire ([\element-hq#9098](matrix-org/matrix-react-sdk#9098)). Contributed by @kerryarchibald.
* Some slash-commands (`/myroomnick`) have temporarily been disabled before the first message in a DM is sent. ([\element-hq#9193](matrix-org/matrix-react-sdk#9193)).
* Use stable reference for active tab in tabbedView ([\#9145](matrix-org/matrix-react-sdk#9145)). Contributed by @kerryarchibald.
* Fix pillification sometimes doubling up ([\element-hq#9152](matrix-org/matrix-react-sdk#9152)). Fixes element-hq#23036.
* Fix highlights not being applied to plaintext messages ([\element-hq#9126](matrix-org/matrix-react-sdk#9126)). Fixes element-hq#22787.
* Fix dismissing edit composer when change was undone ([\element-hq#9109](matrix-org/matrix-react-sdk#9109)). Fixes element-hq#22932.
* 1-to-1 DM rooms with bots now act like DM rooms instead of multi-user-rooms before ([\element-hq#9124](matrix-org/matrix-react-sdk#9124)). Fixes element-hq#22894.
* Apply inline start padding to selected lines on modern layout only ([\element-hq#9006](matrix-org/matrix-react-sdk#9006)). Fixes element-hq#22768. Contributed by @luixxiul.
* Peek into world-readable rooms from spotlight ([\element-hq#9115](matrix-org/matrix-react-sdk#9115)). Fixes element-hq#22862.
* Use default styling on nested numbered lists due to MD being sensitive ([\element-hq#9110](matrix-org/matrix-react-sdk#9110)). Fixes element-hq#22935.
* Fix replying using chat effect commands ([\element-hq#9101](matrix-org/matrix-react-sdk#9101)). Fixes element-hq#22824.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Invite A-Room-Upgrades P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Won't-Fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @lampholder