Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registration failure #9581

Closed
ara4n opened this issue Apr 28, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#2967
Closed

Registration failure #9581

ara4n opened this issue Apr 28, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#2967
Assignees
@dbkr
Labels
A-Registration T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Apr 28, 2019

I just tried a typical registration flow on riot.im/app - signing up as matthewtest17. I copied the verification link from my mail client into the browser, did the captcha, clicked the T&Cs, and then got logged in as a Guest rather than matthewtest17. This triggered two weird errors: "To do this action, you must register" (despite me having registered), and then a warning that I was logged in a guest whilst trying to do behaviour as a registered user. I then explicitly chose login from the TopLeftMenu to re-login as matthewtest17. :-/
@ara4n ara4n added the T-Defect label Apr 28, 2019
@lampholder
Copy link
Member

Coudl be related to #9480

@turt2live
Copy link
Member

fwiw the code that tries to make this less of a disaster hasn't landed on /app yet - see also #6875

@ara4n ara4n mentioned this issue May 11, 2019
Closed
@ara4n
Copy link
Member Author

ara4n commented May 11, 2019

I just this happen again, on signing up another new test account on riot.im/app (now on 1.1).

This feels like registration is just completely broken right now, and has been for several weeks?!

@dbkr dbkr self-assigned this May 13, 2019
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue May 14, 2019
@dbkr
Fix email registration, pt. 2
c11d26d 
Regressed in #2768
where we check for an existing stored account first and restore that
instead if it exist, telling the user. We usually make a guest account
when the user first hits the page though, so this just restored this
guest account.

Don't restore the account if it's just a guest account (which, as per
comment, is not perfect, but is definitely better than the current
behaviour).

Fixes element-hq/element-web#9581
@dbkr dbkr mentioned this issue May 14, 2019
Merged
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue May 14, 2019
@dbkr
Fix email registration, pt. 2
040424f 
Regressed in #2768
where we check for an existing stored account first and restore that
instead if it exist, telling the user. We usually make a guest account
when the user first hits the page though, so this just restored this
guest account.

Don't restore the account if it's just a guest account (which, as per
comment, is not perfect, but is definitely better than the current
behaviour).

Fixes element-hq/element-web#9581
su-ex added a commit to SchildiChat/element-web that referenced this issue Dec 6, 2022
@su-ex
Merge tag 'v1.11.16' into sc
58d68a5 
* Further improve replies ([\element-hq#6396](matrix-org/matrix-react-sdk#6396)). Fixes element-hq#19074, element-hq#18194 element-hq#18027 and element-hq#19179.
* Enable users to join group calls from multiple devices ([\element-hq#9625](matrix-org/matrix-react-sdk#9625)).
* fix(visual): make cursor a pointer for summaries ([\element-hq#9419](matrix-org/matrix-react-sdk#9419)). Contributed by @r00ster91.
* Add placeholder for rich text editor ([\element-hq#9613](matrix-org/matrix-react-sdk#9613)).
* Consolidate public room search experience ([\element-hq#9605](matrix-org/matrix-react-sdk#9605)). Fixes element-hq#22846.
* New password reset flow ([\element-hq#9581](matrix-org/matrix-react-sdk#9581)). Fixes element-hq#23131.
* Device manager - add tooltip to device details toggle ([\#9594](matrix-org/matrix-react-sdk#9594)).
* sliding sync: add lazy-loading member support ([\element-hq#9530](matrix-org/matrix-react-sdk#9530)).
* Limit formatting bar offset to top of composer ([\element-hq#9365](matrix-org/matrix-react-sdk#9365)). Fixes element-hq#12359. Contributed by @owi92.
* Fix issues around up arrow event edit shortcut ([\element-hq#9645](matrix-org/matrix-react-sdk#9645)). Fixes element-hq#18497 and element-hq#18964.
* Fix search not being cleared when clicking on a result ([\element-hq#9635](matrix-org/matrix-react-sdk#9635)). Fixes element-hq#23845.
* Fix screensharing in 1:1 calls ([\element-hq#9612](matrix-org/matrix-react-sdk#9612)). Fixes element-hq#23808.
* Fix the background color flashing when joining a call ([\element-hq#9640](matrix-org/matrix-react-sdk#9640)).
* Fix the size of the 'Private space' icon ([\element-hq#9638](matrix-org/matrix-react-sdk#9638)).
* Fix reply editing in rich text editor (https ([\element-hq#9615](matrix-org/matrix-react-sdk#9615)).
* Fix thread list jumping back down while scrolling ([\element-hq#9606](matrix-org/matrix-react-sdk#9606)). Fixes element-hq#23727.
* Fix regression with TimelinePanel props updates not taking effect ([\element-hq#9608](matrix-org/matrix-react-sdk#9608)). Fixes element-hq#23794.
* Fix form tooltip positioning ([\element-hq#9598](matrix-org/matrix-react-sdk#9598)). Fixes element-hq#22861.
* Extract Search handling from RoomView into its own Component ([\element-hq#9574](matrix-org/matrix-react-sdk#9574)). Fixes element-hq#498.
* Fix call splitbrains when switching between rooms ([\element-hq#9692](matrix-org/matrix-react-sdk#9692)).
* [Backport staging] Fix replies to emotes not showing as inline ([\element-hq#9708](matrix-org/matrix-react-sdk#9708)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
A-Registration T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix registration with email matrix-org/matrix-react-sdk
4 participants
@dbkr @turt2live @ara4n @lampholder