Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to easily click reply or [...] buttons #9650

Closed
michaelkaye opened this issue May 8, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#3227
Closed

Unable to easily click reply or [...] buttons #9650

michaelkaye opened this issue May 8, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#3227

Comments

@michaelkaye
Copy link
Contributor

riot-bug

Description

New location of reply and [...] menu is very hard to select. The overlapping with the previous section means that when you mouse into the red area, (which is very easy when attempting to move the mouse to these buttons) you end up moving the message selection to the previous message instead.

That then needs us to move back to the message we wanted to select then try, slower, to get to the button again.

This is incredibly frustrating compared to the previous UI, especially if using a trackpad (in my case) or i imagine for users with pointer control issues - you have to hit a 5mm target and are not allowed to overshoot.

A fix would be not to deselect this message if you enter the red area near the buttons, or put the buttons inside the message itself so that overshoots don't tend to select another message

Version information

  • Platform: web (in-browser) or desktop?

For the web app:

  • Browser: Firefox
  • OS: Debian
  • URL: riot.im/app
@michaelkaye
Copy link
Contributor Author

Further, this only seems to kick in when looking at messages that don't have a change in user - if you change user there's a dead zone between this message and the previous one where this doesn't kick in - so only /sometimes/ do you have to be very precise with your mouse movement.

@jryans
Copy link
Collaborator

jryans commented May 9, 2019

@nadonomy, should we try to extend an invisible area around the action bar to make it easier to hit? I believe you're also considering tweaks to the action bar position in general, so it seemed good to have this on your radar.

@nadonomy
Copy link
Contributor

nadonomy commented May 9, 2019

I think this is also down to our UI being slightly too small in general too, I find I'm often zoomed in at 110-120%, but definitely out of the scope of this issue. 😉

@jryans Making the hit targets for the buttons bigger, if we have a simple way to do that, sounds good to me. Possibly in conjunction with increasing the button size all round?

The changes I'm going to look at are mostly colour related, along with possibly (ab)using css gradients or box shadows to stop buttons from directly bleeding into text.

@jryans
Copy link
Collaborator

jryans commented Jul 11, 2019

I believe I can address this with an invisible safe area around the action bar.

jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 11, 2019
This adds a previous event safe area so that you can't accidentally hover the
previous event while trying to mouse into the action bar or from the react
button to its tooltip.

Part of element-hq/element-web#10185
Fixes element-hq/element-web#9650
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 17, 2019
This adds a previous event safe area so that you can't accidentally hover the
previous event while trying to mouse into the action bar or from the react
button to its tooltip.

Part of element-hq/element-web#10185
Fixes element-hq/element-web#9650
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 17, 2019
This adds a previous event safe area so that you can't accidentally hover the
previous event while trying to mouse into the action bar or from the react
button to its tooltip.

Part of element-hq/element-web#10185
Fixes element-hq/element-web#9650
@jryans
Copy link
Collaborator

jryans commented Jul 17, 2019

This has also been merged to the Riot 1.3.0 release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants