Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactions: Local echo undo of reaction via redaction #9675

Closed
jryans opened this issue May 10, 2019 · 3 comments
Closed

Reactions: Local echo undo of reaction via redaction #9675

jryans opened this issue May 10, 2019 · 3 comments
Assignees
@bwindels
Labels
A-Aggregations A-Reactions T-Enhancement

Comments

@jryans
Copy link
Collaborator

jryans commented May 10, 2019

We currently don't local echo for redactions (of any kind). This means that undoing a reaction (which uses redactions) feels quite slow. We should support local echo of redactions at least for reactions specifically, but perhaps also for any kind of redaction as well (if that's easy to do).
@jryans jryans mentioned this issue May 10, 2019
Merged
@BillCarsonFr BillCarsonFr mentioned this issue May 28, 2019
Closed
@lampholder
Copy link
Member

Similar rationale to #9739, this is being bumped from phase:1 to phase:2

  • it's not mvp for reactions

@lampholder lampholder added phase:1 and removed phase:2 labels Jun 3, 2019
@lampholder
Copy link
Member

We've decided this is MVP for reactions :D

@bwindels bwindels self-assigned this Jun 3, 2019
@bwindels bwindels mentioned this issue Jun 3, 2019
Merged
@jryans
Copy link
Collaborator Author

jryans commented Jun 5, 2019

Fixed by matrix-org/matrix-js-sdk#937 and matrix-org/matrix-react-sdk#3058.

@jryans jryans closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwindels bwindels

Labels
A-Aggregations A-Reactions T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bwindels @jryans @lampholder