Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add focus border to edit composer #9739

Closed
ara4n opened this issue May 16, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#3145
Closed

Add focus border to edit composer #9739

ara4n opened this issue May 16, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#3145

Comments

@ara4n
Copy link
Member

ara4n commented May 16, 2019

If you hit tab whilst a selection is active on the new composer, keyboard focus heads off somewhere else (where) but there is no visual cue this has happened at all? Same if no selection is active, but at least the cursor disappears.

@bwindels
Copy link
Contributor

bwindels commented May 22, 2019

hmm, I have seen this last week, but now can't repro anymore ...

@bwindels
Copy link
Contributor

As for the confused state, can't repro anymore as mentioned, but perhaps the editor should have a focus border of some sort @nadonomy ?

@bwindels
Copy link
Contributor

image

Nad: this is what 50% opacity looks like, any more and it's visually distracting

@lampholder
Copy link
Member

I'm bumping this from phase:1 to phase:2 because:

  • phase 1 was essentially MVP, and this isn't MVP
  • we've completed phase 1, and this wasn't in it 😄

We do need to have a separate chat (for this and reactions) agreeing exactly what phase 2 comprised and its anticipated delivery date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants