Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highlighted messages shouldn't have bright red reaction button text #9697

Closed
ara4n opened this issue May 13, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3081
Closed

highlighted messages shouldn't have bright red reaction button text #9697

ara4n opened this issue May 13, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3081
Assignees
@jryans
Labels
A-Aggregations A-Reactions P1 S-Tolerable Low/no impact on users T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented May 13, 2019

No description provided.

@turt2live turt2live mentioned this issue May 14, 2019
Closed
@turt2live turt2live mentioned this issue May 14, 2019
Closed
@lampholder lampholder added S-Tolerable Low/no impact on users P1 labels May 16, 2019
@turt2live turt2live mentioned this issue May 22, 2019
Closed
@anoadragon453
Copy link
Member

Ex:

image

@jryans jryans added the phase:2 label Jun 7, 2019
@jryans jryans self-assigned this Jun 7, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 7, 2019
@jryans
Remove highlight from reactions
3320fd9 
This explicitly sets `color` for the reactions row to ensure it's always the fg
colour, even if the event is highlighted.

Fixes element-hq/element-web#9697
@jryans jryans mentioned this issue Jun 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Aggregations A-Reactions P1 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove highlight from reactions matrix-org/matrix-react-sdk
5 participants
@jryans @turt2live @ara4n @anoadragon453 @lampholder