Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message editing: take server-side replaced event into account for (edited) marker #9834

Closed
bwindels opened this issue May 24, 2019 · 2 comments
Closed

Message editing: take server-side replaced event into account for (edited) marker #9834

bwindels opened this issue May 24, 2019 · 2 comments
Assignees
@bwindels
Labels
A-Aggregations A-Message-Editing T-Enhancement

Comments

@bwindels
Copy link
Contributor

bwindels commented May 24, 2019 •
edited
Loading

Also look into unsigned / m.relations / m.replace / event_id to see if an event was edited. This is how the server marks aggregated edits, which is the only way we can find out for backpaginating and /context, etc...

The event's content should already be the content of the replacing event.

See matrix-org/matrix-spec-proposals#1849 (comment) as well.

Related to #9743
@bwindels
Copy link
Contributor Author

We'll probably need origin_server_ts and sender in the server-side aggregated data, see matrix-org/matrix-spec-proposals#1849 (comment) so blocking this on resolution of that issue.

@bwindels bwindels mentioned this issue Jul 2, 2019
Closed
This was referenced Jul 9, 2019
Merged
Merged
@bwindels bwindels removed the X-Blocked label Jul 9, 2019
@bwindels
Copy link
Contributor Author

bwindels commented Jul 9, 2019 •
edited
Loading

Seems like the server support has already been implemented for this on synapse/develop.

@bwindels bwindels closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwindels bwindels

Labels
A-Aggregations A-Message-Editing T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bwindels @jryans