Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregations: Use backend support #9743

Open
jryans opened this issue May 16, 2019 · 4 comments
Open

Aggregations: Use backend support #9743

jryans opened this issue May 16, 2019 · 4 comments
Labels
A-Aggregations A-Message-Editing A-Reactions T-Enhancement X-Blocked Z-t3chguy

Comments

@jryans
Copy link
Collaborator

jryans commented May 16, 2019

This is a placeholder issue for things like:

  • Applying bundled relations from sync
  • Paginating relations

At the moment, Riot Web does all this client-side without assistance from the server, but this likely means we'll miss relations when there's a gappy sync, etc.
@bwindels bwindels mentioned this issue May 24, 2019
Closed
@jryans
Copy link
Collaborator Author

jryans commented May 31, 2019 •
edited
Loading

At the moment, it feels hard to be sure how to interpret the bundled relations correctly.

In the case of reactions for example:

  • If you scroll back and get the target event with bundled reactions, you don't know which reaction events are included, so you don't know whether to add / remove for later events in the timeline (MSC comment)
  • Bundled data doesn't currently include reaction senders which we show in the hover tooltip (MSC comment)

@jryans
Copy link
Collaborator Author

jryans commented Jun 5, 2019

Marking as blocked until these spec concerns have a clear resolution.

@lampholder lampholder added phase:3 and removed phase:2 labels Jul 2, 2019
@bwindels
Copy link
Contributor

Related: #10330

@t3chguy t3chguy mentioned this issue Apr 28, 2022
Closed
@turt2live
Copy link
Member

ftr, this causes bugs like #22078 because it doesn't really know what the relations are.

@turt2live turt2live mentioned this issue May 7, 2022
Closed
@t3chguy t3chguy mentioned this issue May 11, 2022
Closed
su-ex added a commit to SchildiChat/element-web that referenced this issue Jan 15, 2023
@su-ex
Merge tag 'v1.11.17' into sc
eac9806 
* Add inline code formatting to rich text editor ([\element-hq#9720](matrix-org/matrix-react-sdk#9720)).
* Add emoji handling for plain text mode of the new rich text editor ([\element-hq#9727](matrix-org/matrix-react-sdk#9727)).
* Overlay virtual room call events into main timeline ([\element-hq#9626](matrix-org/matrix-react-sdk#9626)). Fixes element-hq#22929.
* Adds a new section under "Room Settings" > "Roles & Permissions" which adds the possibility to multiselect users from this room and grant them more permissions. ([\element-hq#9596](matrix-org/matrix-react-sdk#9596)). Contributed by @GoodGuyMarco.
* Add emoji handling for rich text mode ([\element-hq#9661](matrix-org/matrix-react-sdk#9661)).
* Add setting to hide bold notifications ([\element-hq#9705](matrix-org/matrix-react-sdk#9705)).
* Further password reset flow enhancements ([\element-hq#9662](matrix-org/matrix-react-sdk#9662)).
* Snooze the bulk unverified sessions reminder on dismiss ([\element-hq#9706](matrix-org/matrix-react-sdk#9706)).
* Honor advanced audio processing settings when recording voice messages ([\element-hq#9610](matrix-org/matrix-react-sdk#9610)). Contributed by @MrAnno.
* Improve the visual balance of bubble layout ([\element-hq#9704](matrix-org/matrix-react-sdk#9704)).
* Add config setting to disable bulk unverified sessions nag ([\element-hq#9657](matrix-org/matrix-react-sdk#9657)).
* Only display bulk unverified sessions nag when current sessions is verified ([\element-hq#9656](matrix-org/matrix-react-sdk#9656)).
* Separate labs and betas more clearly ([\element-hq#8969](matrix-org/matrix-react-sdk#8969)). Fixes element-hq#22706.
* Show user an error if we fail to create a DM for verification. ([\element-hq#9624](matrix-org/matrix-react-sdk#9624)).
* Prevent unnecessary m.direct updates ([\element-hq#9805](matrix-org/matrix-react-sdk#9805)). Fixes element-hq#24059.
* Fix checkForPreJoinUISI for thread roots ([\element-hq#9803](matrix-org/matrix-react-sdk#9803)). Fixes element-hq#24054.
* Load RTE components only when RTE labs is enabled ([\element-hq#9804](matrix-org/matrix-react-sdk#9804)).
* Fix issue where thread panel did not update correctly ([\element-hq#9746](matrix-org/matrix-react-sdk#9746)). Fixes element-hq#23971.
* Remove async call to get virtual room from room load ([\element-hq#9743](matrix-org/matrix-react-sdk#9743)). Fixes element-hq#23968.
* Check each thread for unread messages. ([\element-hq#9723](matrix-org/matrix-react-sdk#9723)).
* Device manage - handle sessions that don't support encryption ([\element-hq#9717](matrix-org/matrix-react-sdk#9717)). Fixes element-hq#23722.
* Fix hover state for formatting buttons (Rich text editor) (fix element-hq/issues/23832) ([\element-hq#9715](matrix-org/matrix-react-sdk#9715)).
* Don't allow group calls to be unterminated ([\element-hq#9710](matrix-org/matrix-react-sdk#9710)).
* Fix replies to emotes not showing as inline ([\element-hq#9707](matrix-org/matrix-react-sdk#9707)). Fixes element-hq#23903.
* Update copy of 'Change layout' button to match Element Call ([\element-hq#9703](matrix-org/matrix-react-sdk#9703)).
* Fix call splitbrains when switching between rooms ([\element-hq#9692](matrix-org/matrix-react-sdk#9692)).
* bugfix: fix an issue where the Notifier would incorrectly fire for non-timeline events ([\element-hq#9664](matrix-org/matrix-react-sdk#9664)). Fixes element-hq#17263.
* Fix power selector being wrongly disabled for admins themselves ([\element-hq#9681](matrix-org/matrix-react-sdk#9681)). Fixes element-hq#23882.
* Show day counts in call durations ([\element-hq#9641](matrix-org/matrix-react-sdk#9641)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Aggregations A-Message-Editing A-Reactions T-Enhancement X-Blocked Z-t3chguy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bwindels @jryans @turt2live @lampholder @t3chguy