Remove highlight.js CSS #19483
Merged
Remove highlight.js CSS #19483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was completely unnecessary: react-sdk includes appropriate CSS for highlight.js in its themes. This was actually causing some of those values to be overridden with silly ones that made text invisible on the dark theme. Fixes #19476
turt2live
approved these changes
Oct 22, 2021
RiotRobot
pushed a commit
that referenced
this pull request
Oct 25, 2021
This was completely unnecessary: react-sdk includes appropriate CSS for highlight.js in its themes. This was actually causing some of those values to be overridden with silly ones that made text invisible on the dark theme. Fixes #19476
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Oct 29, 2021
Changes in [1.9.3](https://github.com/vector-im/element-desktop/releases/tag/v1.9.3) (2021-10-25) ================================================================================================= ## ✨ Features * Convert the "Cryptography" settings panel to an HTML table to assist screen reader users. ([\#6968](matrix-org/matrix-react-sdk#6968)). Contributed by [andybalaam](https://github.com/andybalaam). * Swap order of private space creation and tweak copy ([\#6967](matrix-org/matrix-react-sdk#6967)). Fixes #18768 and #18768. * Add spacing to Room settings - Notifications subsection ([\#6962](matrix-org/matrix-react-sdk#6962)). Contributed by [CicadaCinema](https://github.com/CicadaCinema). * Use HTML tables for some tabular user interface areas, to assist with screen reader use ([\#6955](matrix-org/matrix-react-sdk#6955)). Contributed by [andybalaam](https://github.com/andybalaam). * Fix space invite edge cases ([\#6884](matrix-org/matrix-react-sdk#6884)). Fixes #19010 #17345 and #19010. * Allow options to cascade kicks/bans throughout spaces ([\#6829](matrix-org/matrix-react-sdk#6829)). Fixes #18969 and #18969. * Make public space alias field mandatory again ([\#6921](matrix-org/matrix-react-sdk#6921)). Fixes #19003 and #19003. * Add progress bar to restricted room upgrade dialog ([\#6919](matrix-org/matrix-react-sdk#6919)). Fixes #19146 and #19146. * Add customisation point for visibility of invites and room creation ([\#6922](matrix-org/matrix-react-sdk#6922)). Fixes #19331 and #19331. * Inhibit `Unable to get validated threepid` error during UIA ([\#6928](matrix-org/matrix-react-sdk#6928)). Fixes #18883 and #18883. * Tweak room list skeleton UI height and behaviour ([\#6926](matrix-org/matrix-react-sdk#6926)). Fixes #18231 #16581 and #18231. * If public room creation fails, retry without publishing it ([\#6872](matrix-org/matrix-react-sdk#6872)). Fixes #19194 and #19194. Contributed by [AndrewFerr](https://github.com/AndrewFerr). * Iterate invite your teammates to Space view ([\#6925](matrix-org/matrix-react-sdk#6925)). Fixes #18772 and #18772. * Make placeholder more grey when no input ([\#6840](matrix-org/matrix-react-sdk#6840)). Fixes #17243 and #17243. Contributed by [wlach](https://github.com/wlach). * Respect tombstones in locally known rooms for Space children ([\#6906](matrix-org/matrix-react-sdk#6906)). Fixes #19246 #19256 and #19246. * Improve emoji shortcodes generated from annotations ([\#6907](matrix-org/matrix-react-sdk#6907)). Fixes #19304 and #19304. * Hide kick & ban options in UserInfo when looking at own profile ([\#6911](matrix-org/matrix-react-sdk#6911)). Fixes #19066 and #19066. * Add progress bar to Community to Space migration tool ([\#6887](matrix-org/matrix-react-sdk#6887)). Fixes #19216 and #19216. ## 🐛 Bug Fixes * Fix leave space cancel button exploding ([\#6966](matrix-org/matrix-react-sdk#6966)). * Fix edge case behaviour of the space join spinner for guests ([\#6972](matrix-org/matrix-react-sdk#6972)). Fixes #19359 and #19359. * Convert emoticon to emoji at the end of a line on send even if the cursor isn't there ([\#6965](matrix-org/matrix-react-sdk#6965)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix text overflows button on Home page ([\#6898](matrix-org/matrix-react-sdk#6898)). Fixes #19180 and #19180. Contributed by [oliver-pham](https://github.com/oliver-pham). * Space Room View should react to join rule changes down /sync ([\#6945](matrix-org/matrix-react-sdk#6945)). Fixes #19390 and #19390. * Hide leave section button if user isn't in the room e.g peeking ([\#6920](matrix-org/matrix-react-sdk#6920)). Fixes #17410 and #17410. * Fix bug where room list would get stuck showing no rooms ([\#6939](matrix-org/matrix-react-sdk#6939)). Fixes #19373 and #19373. * Update room settings dialog title when room name changes ([\#6916](matrix-org/matrix-react-sdk#6916)). Fixes #17480 and #17480. Contributed by [psrpinto](https://github.com/psrpinto). * Fix editing losing emote-ness and rainbow-ness of messages ([\#6931](matrix-org/matrix-react-sdk#6931)). Fixes #19350 and #19350. * Remove semicolon from notifications panel ([\#6930](matrix-org/matrix-react-sdk#6930)). Contributed by [robintown](https://github.com/robintown). * Prevent profile image in left panel's backdrop from being selected ([\#6924](matrix-org/matrix-react-sdk#6924)). Contributed by [rom4nik](https://github.com/rom4nik). * Validate that the phone number verification field is filled before allowing user to submit ([\#6918](matrix-org/matrix-react-sdk#6918)). Fixes #19316 and #19316. Contributed by [VFermat](https://github.com/VFermat). * Updated how save button becomes disabled in room settings to listen for all fields instead of the most recent ([\#6917](matrix-org/matrix-react-sdk#6917)). Contributed by [LoganArnett](https://github.com/LoganArnett). * Use FocusLock around ContextMenus to simplify focus management ([\#6311](matrix-org/matrix-react-sdk#6311)). Fixes #19259 and #19259. * Fix space hierarchy pagination ([\#6908](matrix-org/matrix-react-sdk#6908)). Fixes #19276 and #19276. * Fix spaces keyboard shortcuts not working for last space ([\#6909](matrix-org/matrix-react-sdk#6909)). Fixes #19255 and #19255. * Use fallback avatar only for DMs with 2 people. ([\#6895](matrix-org/matrix-react-sdk#6895)). Fixes #18747 and #18747. Contributed by [andybalaam](https://github.com/andybalaam). Changes in [1.9.3-rc.3](https://github.com/vector-im/element-desktop/releases/tag/v1.9.3-rc.3) (2021-10-25) =========================================================================================================== ## 🐛 Bug Fixes * Remove highlightjs CSS ([\#19483](element-hq/element-web#19483)). Fixes element-hq/element-web#19476 Changes in [1.9.3-rc.2](https://github.com/vector-im/element-desktop/releases/tag/v1.9.3-rc.2) (2021-10-20) =========================================================================================================== ## 🐛 Bug Fixes * Fix conflicting CSS on syntax highlighted blocks ([\#6991](matrix-org/matrix-react-sdk#6991)). Fixes element-hq/element-web#19445 Changes in [1.9.3-rc.1](https://github.com/vector-im/element-desktop/releases/tag/v1.9.3-rc.1) (2021-10-19) =========================================================================================================== ## ✨ Features * Swap order of private space creation and tweak copy ([\#6967](matrix-org/matrix-react-sdk#6967)). Fixes #18768 and #18768. * Add spacing to Room settings - Notifications subsection ([\#6962](matrix-org/matrix-react-sdk#6962)). Contributed by [CicadaCinema](https://github.com/CicadaCinema). * Convert the "Cryptography" settings panel to an HTML to assist screen reader users. ([\#6968](matrix-org/matrix-react-sdk#6968)). Contributed by [andybalaam](https://github.com/andybalaam). * Use HTML tables for some tabular user interface areas, to assist with screen reader use ([\#6955](matrix-org/matrix-react-sdk#6955)). Contributed by [andybalaam](https://github.com/andybalaam). * Fix space invite edge cases ([\#6884](matrix-org/matrix-react-sdk#6884)). Fixes #19010 #17345 and #19010. * Allow options to cascade kicks/bans throughout spaces ([\#6829](matrix-org/matrix-react-sdk#6829)). Fixes #18969 and #18969. * Make public space alias field mandatory again ([\#6921](matrix-org/matrix-react-sdk#6921)). Fixes #19003 and #19003. * Add progress bar to restricted room upgrade dialog ([\#6919](matrix-org/matrix-react-sdk#6919)). Fixes #19146 and #19146. * Add customisation point for visibility of invites and room creation ([\#6922](matrix-org/matrix-react-sdk#6922)). Fixes #19331 and #19331. * Inhibit `Unable to get validated threepid` error during UIA ([\#6928](matrix-org/matrix-react-sdk#6928)). Fixes #18883 and #18883. * Tweak room list skeleton UI height and behaviour ([\#6926](matrix-org/matrix-react-sdk#6926)). Fixes #18231 #16581 and #18231. * If public room creation fails, retry without publishing it ([\#6872](matrix-org/matrix-react-sdk#6872)). Fixes #19194 and #19194. Contributed by [AndrewFerr](https://github.com/AndrewFerr). * Iterate invite your teammates to Space view ([\#6925](matrix-org/matrix-react-sdk#6925)). Fixes #18772 and #18772. * Make placeholder more grey when no input ([\#6840](matrix-org/matrix-react-sdk#6840)). Fixes #17243 and #17243. Contributed by [wlach](https://github.com/wlach). * Respect tombstones in locally known rooms for Space children ([\#6906](matrix-org/matrix-react-sdk#6906)). Fixes #19246 #19256 and #19246. * Improve emoji shortcodes generated from annotations ([\#6907](matrix-org/matrix-react-sdk#6907)). Fixes #19304 and #19304. * Hide kick & ban options in UserInfo when looking at own profile ([\#6911](matrix-org/matrix-react-sdk#6911)). Fixes #19066 and #19066. * Add progress bar to Community to Space migration tool ([\#6887](matrix-org/matrix-react-sdk#6887)). Fixes #19216 and #19216. ## 🐛 Bug Fixes * Fix leave space cancel button exploding ([\#6966](matrix-org/matrix-react-sdk#6966)). * Fix edge case behaviour of the space join spinner for guests ([\#6972](matrix-org/matrix-react-sdk#6972)). Fixes #19359 and #19359. * Convert emoticon to emoji at the end of a line on send even if the cursor isn't there ([\#6965](matrix-org/matrix-react-sdk#6965)). Contributed by [SimonBrandner](https://github.com/SimonBrandner). * Fix text overflows button on Home page ([\#6898](matrix-org/matrix-react-sdk#6898)). Fixes #19180 and #19180. Contributed by [oliver-pham](https://github.com/oliver-pham). * Space Room View should react to join rule changes down /sync ([\#6945](matrix-org/matrix-react-sdk#6945)). Fixes #19390 and #19390. * Hide leave section button if user isn't in the room e.g peeking ([\#6920](matrix-org/matrix-react-sdk#6920)). Fixes #17410 and #17410. * Fix bug where room list would get stuck showing no rooms ([\#6939](matrix-org/matrix-react-sdk#6939)). Fixes #19373 and #19373. * Update room settings dialog title when room name changes ([\#6916](matrix-org/matrix-react-sdk#6916)). Fixes #17480 and #17480. Contributed by [psrpinto](https://github.com/psrpinto). * Fix editing losing emote-ness and rainbow-ness of messages ([\#6931](matrix-org/matrix-react-sdk#6931)). Fixes #19350 and #19350. * Remove semicolon from notifications panel ([\#6930](matrix-org/matrix-react-sdk#6930)). Contributed by [robintown](https://github.com/robintown). * Prevent profile image in left panel's backdrop from being selected ([\#6924](matrix-org/matrix-react-sdk#6924)). Contributed by [rom4nik](https://github.com/rom4nik). * Validate that the phone number verification field is filled before allowing user to submit ([\#6918](matrix-org/matrix-react-sdk#6918)). Fixes #19316 and #19316. Contributed by [VFermat](https://github.com/VFermat). * Updated how save button becomes disabled in room settings to listen for all fields instead of the most recent ([\#6917](matrix-org/matrix-react-sdk#6917)). Contributed by [LoganArnett](https://github.com/LoganArnett). * Use FocusLock around ContextMenus to simplify focus management ([\#6311](matrix-org/matrix-react-sdk#6311)). Fixes #19259 and #19259. * Fix space hierarchy pagination ([\#6908](matrix-org/matrix-react-sdk#6908)). Fixes #19276 and #19276. * Fix spaces keyboard shortcuts not working for last space ([\#6909](matrix-org/matrix-react-sdk#6909)). Fixes #19255 and #19255. * Use fallback avatar only for DMs with 2 people. ([\#6895](matrix-org/matrix-react-sdk#6895)). Fixes #18747 and #18747. Contributed by [andybalaam](https://github.com/andybalaam). Changes in [1.9.2](https://github.com/vector-im/element-desktop/releases/tag/v1.9.2) (2021-10-12) ================================================================================================= ## 🐛 Bug Fixes * Upgrade to matrix-js-sdk#14.0.1 Changes in [1.9.1](https://github.com/vector-im/element-desktop/releases/tag/v1.9.1) (2021-10-11) ================================================================================================= ## ✨ Features * Decrease profile button touch target ([\#6900](matrix-org/matrix-react-sdk#6900)). Contributed by [ColonisationCaptain](https://github.com/ColonisationCaptain). * Don't let click events propagate out of context menus ([\#6892](matrix-org/matrix-react-sdk#6892)). * Allow closing Dropdown via its chevron ([\#6885](matrix-org/matrix-react-sdk#6885)). Fixes #19030 and #19030. * Improve AUX panel behaviour ([\#6699](matrix-org/matrix-react-sdk#6699)). Fixes #18787 and #18787. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * A nicer opening animation for the Image View ([\#6454](matrix-org/matrix-react-sdk#6454)). Fixes #18186 and #18186. Contributed by [SimonBrandner](https://github.com/SimonBrandner). ## 🐛 Bug Fixes * [Release] Fix space hierarchy pagination ([\#6910](matrix-org/matrix-react-sdk#6910)). * Fix leaving space via other client leaving you in undefined-land ([\#6891](matrix-org/matrix-react-sdk#6891)). Fixes #18455 and #18455. * Handle newer voice message encrypted event format for chat export ([\#6893](matrix-org/matrix-react-sdk#6893)). Contributed by [jaiwanth-v](https://github.com/jaiwanth-v). * Fix pagination when filtering space hierarchy ([\#6876](matrix-org/matrix-react-sdk#6876)). Fixes #19235 and #19235. * Fix spaces null-guard breaking the dispatcher settings watching ([\#6886](matrix-org/matrix-react-sdk#6886)). Fixes #19223 and #19223. * Fix space children without specific `order` being sorted after those with one ([\#6878](matrix-org/matrix-react-sdk#6878)). Fixes #19192 and #19192. * Ensure that sub-spaces aren't considered for notification badges ([\#6881](matrix-org/matrix-react-sdk#6881)). Fixes #18975 and #18975. * Fix timeline autoscroll with non-standard DPI settings. ([\#6880](matrix-org/matrix-react-sdk#6880)). Fixes #18984 and #18984. * Pluck out JoinRuleSettings styles so they apply in space settings too ([\#6879](matrix-org/matrix-react-sdk#6879)). Fixes #19164 and #19164. * Null guard around the matrixClient in SpaceStore ([\#6874](matrix-org/matrix-react-sdk#6874)). * Fix issue (https ([\#6871](matrix-org/matrix-react-sdk#6871)). Fixes #19138 and #19138. Contributed by [psrpinto](https://github.com/psrpinto). * Fix pills being cut off in message bubble layout ([\#6865](matrix-org/matrix-react-sdk#6865)). Fixes #18627 and #18627. Contributed by [robintown](https://github.com/robintown). * Fix space admin check false positive on multiple admins ([\#6824](matrix-org/matrix-react-sdk#6824)). * Fix the User View ([\#6860](matrix-org/matrix-react-sdk#6860)). Fixes #19158 and #19158. * Fix spacing for message composer buttons ([\#6852](matrix-org/matrix-react-sdk#6852)). Fixes #18999 and #18999. * Always show root event of a thread in room's timeline ([\#6842](matrix-org/matrix-react-sdk#6842)). Fixes #19016 and #19016. Changes in [1.9.1-rc.2](https://github.com/vector-im/element-desktop/releases/tag/v1.9.1-rc.2) (2021-10-08) =========================================================================================================== ## 🐛 Bug Fixes Changes in [1.9.1-rc.1](https://github.com/vector-im/element-desktop/releases/tag/v1.9.1-rc.1) (2021-10-04) =========================================================================================================== ## ✨ Features * Decrease profile button touch target ([\#6900](matrix-org/matrix-react-sdk#6900)). Contributed by [ColonisationCaptain](https://github.com/ColonisationCaptain). * Don't let click events propagate out of context menus ([\#6892](matrix-org/matrix-react-sdk#6892)). * Allow closing Dropdown via its chevron ([\#6885](matrix-org/matrix-react-sdk#6885)). Fixes #19030 and #19030. * Improve AUX panel behaviour ([\#6699](matrix-org/matrix-react-sdk#6699)). Fixes #18787 and #18787. Contributed by [SimonBrandner](https://github.com/SimonBrandner). * A nicer opening animation for the Image View ([\#6454](matrix-org/matrix-react-sdk#6454)). Fixes #18186 and #18186. Contributed by [SimonBrandner](https://github.com/SimonBrandner). ## 🐛 Bug Fixes * Fix leaving space via other client leaving you in undefined-land ([\#6891](matrix-org/matrix-react-sdk#6891)). Fixes #18455 and #18455. * Handle newer voice message encrypted event format for chat export ([\#6893](matrix-org/matrix-react-sdk#6893)). Contributed by [jaiwanth-v](https://github.com/jaiwanth-v). * Fix pagination when filtering space hierarchy ([\#6876](matrix-org/matrix-react-sdk#6876)). Fixes #19235 and #19235. * Fix spaces null-guard breaking the dispatcher settings watching ([\#6886](matrix-org/matrix-react-sdk#6886)). Fixes #19223 and #19223. * Fix space children without specific `order` being sorted after those with one ([\#6878](matrix-org/matrix-react-sdk#6878)). Fixes #19192 and #19192. * Ensure that sub-spaces aren't considered for notification badges ([\#6881](matrix-org/matrix-react-sdk#6881)). Fixes #18975 and #18975. * Fix timeline autoscroll with non-standard DPI settings. ([\#6880](matrix-org/matrix-react-sdk#6880)). Fixes #18984 and #18984. * Pluck out JoinRuleSettings styles so they apply in space settings too ([\#6879](matrix-org/matrix-react-sdk#6879)). Fixes #19164 and #19164. * Null guard around the matrixClient in SpaceStore ([\#6874](matrix-org/matrix-react-sdk#6874)). * Fix issue (https ([\#6871](matrix-org/matrix-react-sdk#6871)). Fixes #19138 and #19138. Contributed by [psrpinto](https://github.com/psrpinto). * Fix pills being cut off in message bubble layout ([\#6865](matrix-org/matrix-react-sdk#6865)). Fixes #18627 and #18627. Contributed by [robintown](https://github.com/robintown). * Fix space admin check false positive on multiple admins ([\#6824](matrix-org/matrix-react-sdk#6824)). * Fix the User View ([\#6860](matrix-org/matrix-react-sdk#6860)). Fixes #19158 and #19158. * Fix spacing for message composer buttons ([\#6852](matrix-org/matrix-react-sdk#6852)). Fixes #18999 and #18999. * Always show root event of a thread in room's timeline ([\#6842](matrix-org/matrix-react-sdk#6842)). Fixes #19016 and #19016.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was completely unnecessary: react-sdk includes appropriate CSS
for highlight.js in its themes. This was actually causing some of
those values to be overridden with silly ones that made text invisible
on the dark theme.
Fixes #19476
This change has no change notes, so will not be included in the changelog.