Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disabling spell check #22220

Merged
merged 8 commits into from
Jul 28, 2022

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented May 16, 2022

Requires matrix-org/matrix-react-sdk#8604
Requires element-hq/element-desktop#379
Notes: none


This change has no change notes, so will not be included in the changelog.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a bit of context - there's claims on the linked issues that we can't reasonably manage spell check for mac OS, hence the check.

Evidence to the contrary would be nice :)

@SimonBrandner
Copy link
Contributor Author

this needs a bit of context - there's claims on the linked issues that we can't reasonably manage spell check for mac OS, hence the check.

Evidence to the contrary would be nice :)

The method had a rather unideal name :/

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bonus points if all the functions here get their public/private/protected declarations

@SimonBrandner
Copy link
Contributor Author

#22235 :P

@SimonBrandner SimonBrandner changed the title Show spell check settings on macOS Add support for disabling spell check Jun 26, 2022
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

src/vector/platform/ElectronPlatform.tsx Outdated Show resolved Hide resolved
@SimonBrandner SimonBrandner merged commit 1e445a7 into develop Jul 28, 2022
@SimonBrandner SimonBrandner deleted the SimonBrandner/feat/spell-disable branch July 28, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants