-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for disabling spell check #22220
Conversation
Signed-off-by: Šimon Brandner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs a bit of context - there's claims on the linked issues that we can't reasonably manage spell check for mac OS, hence the check.
Evidence to the contrary would be nice :)
Signed-off-by: Šimon Brandner <[email protected]>
The method had a rather unideal name :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bonus points if all the functions here get their public/private/protected declarations
#22235 :P |
Signed-off-by: Šimon Brandner <[email protected]>
…at/spell-disable Signed-off-by: Šimon Brandner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
Co-authored-by: Michael Telatynski <[email protected]>
Requires matrix-org/matrix-react-sdk#8604
Requires element-hq/element-desktop#379
Notes: none
This change has no change notes, so will not be included in the changelog.