Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reactions to html export #28210

Merged
merged 22 commits into from
Oct 18, 2024
Merged

Add reactions to html export #28210

merged 22 commits into from
Oct 18, 2024

Conversation

langleyd
Copy link
Member

Fixes #28134

t3chguy and others added 12 commits October 16, 2024 13:31
@t3chguy @github-merge-queue
@renovate @florianduros @HarHarLinks @MidhunSureshR @dbkr @RiotRobot @richvdh @langleyd @weeman1337 @Timshel @sahil9001 @Half-Shot @uhoreg @AndrewFerr @robintown @tulir
Absorb the matrix-react-sdk repository (#28192)
c05c429 
Co-authored-by: github-merge-queue <[email protected]>
Co-authored-by: github-merge-queue <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Florian Duros <[email protected]>
Co-authored-by: Kim Brose <[email protected]>
Co-authored-by: Florian Duros <[email protected]>
Co-authored-by: R Midhun Suresh <[email protected]>
Co-authored-by: dbkr <[email protected]>
Co-authored-by: ElementRobot <[email protected]>
Co-authored-by: dbkr <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: David Langley <[email protected]>
Co-authored-by: Michael Weimann <[email protected]>
Co-authored-by: Timshel <[email protected]>
Co-authored-by: Sahil Silare <[email protected]>
Co-authored-by: Will Hunt <[email protected]>
Co-authored-by: Hubert Chathi <[email protected]>
Co-authored-by: Andrew Ferrazzutti <[email protected]>
Co-authored-by: Robin <[email protected]>
Co-authored-by: Tulir Asokan <[email protected]>
@renovate
Update dependency @sentry/browser to v8.33.0 [SECURITY] (#28194)
3b75e2a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update babel monorepo (#28196)
8d235bd 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency @types/react to v17.0.83 (#28138)
2a81dc4 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency @matrix-org/spec to v1.12.0 (#28200)
5f7e807 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency @formatjs/intl-segmenter to v11.5.9 (#28197)
f26b51c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@florianduros
Remove references to MatrixClient.crypto (#28204)
f56f814 
* Remove `VerificationExplorer`

* Remove `remakeolm` slash command

* Remove call to `crypto.cancelAndResendAllOutgoingKeyRequests`

* Remove crypto mock in `LoginWithQR-test.tsx`

* Remove `StopGadWidgetDriver.sendToDevice`

* Remove remaining mock
@renovate
Update dependency typescript to v5.6.3 (#28198)
898b6bd 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency eslint-plugin-unicorn to v56 (#28202)
77c822a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency stylelint to v16.10.0 (#28201)
e859efe 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @t3chguy
Update browserslist (#28199)
705625d 
* Update browserslist

* Update tests

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <[email protected]>
@langleyd
Add reactions to html export and add test
a19b9d3
@langleyd langleyd requested a review from a team as a code owner October 16, 2024 20:52
@langleyd langleyd changed the title Add reactions to html export and add test Add reactions to html export Oct 16, 2024
t3chguy
t3chguy approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance of adding this to the screenshot test?

@t3chguy t3chguy requested a review from a team as a code owner October 17, 2024 08:11
@langleyd langleyd requested a review from a team as a code owner October 17, 2024 08:58
@langleyd langleyd requested a review from uhoreg October 17, 2024 08:58
uhoreg
uhoreg approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why crypto review was required for this, since it doesn't seem to touch any crypto code. But, looks fine from a crypto perspective.

@langleyd langleyd added this pull request to the merge queue Oct 18, 2024
Merged via the queue into develop with commit 59cd518 Oct 18, 2024
32 checks passed
@langleyd langleyd deleted the langleyd/add_reactions_to_html_export branch October 18, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@uhoreg uhoreg uhoreg approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chat export doesn't include reactions
4 participants
@langleyd @uhoreg @t3chguy @florianduros