Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove upgrade encryption in DeviceListener and SetupEncryptionToast #28299

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Remove upgrade encryption in DeviceListener and SetupEncryptionToast #28299

merged 2 commits into from
Oct 29, 2024

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Oct 25, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Part of #27455
Task #26922

This was referenced Oct 25, 2024
Open
Merged
@florianduros florianduros force-pushed the florianduros/remove-upgra-encryption-device-listener branch from 8903059 to 11173ab Compare October 25, 2024 14:29
@florianduros florianduros force-pushed the florianduros/remove-upgra-encryption-device-listener branch from 11173ab to f1fce47 Compare October 25, 2024 14:30
@florianduros florianduros marked this pull request as ready for review October 25, 2024 14:50
@florianduros florianduros requested a review from a team as a code owner October 25, 2024 14:50
dbkr
dbkr reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually also making a very similar change but to show the prompt to set up recovery after enabling key backup by default. This may still make sense as an intermediate step to split that out of the PR, essentially.

src/DeviceListener.ts Show resolved Hide resolved
@florianduros florianduros added this pull request to the merge queue Oct 29, 2024
Merged via the queue into develop with commit e5b55db Oct 29, 2024
34 checks passed
@florianduros florianduros deleted the florianduros/remove-upgra-encryption-device-listener branch October 29, 2024 12:46
@florianduros florianduros mentioned this pull request Oct 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @dbkr