Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add colon to timestamp #2857

Closed
wants to merge 1 commit into from
Closed

add colon to timestamp #2857

wants to merge 1 commit into from

Conversation

rubo77
Copy link
Contributor

@rubo77 rubo77 commented Jan 2, 2017

This solves part of the problem that the timestamp is gluing at the message, when copied in your clipboard.

Example:

23:02test message

see #893

This solves part of the problem that the timestamp is  gluing at the message, when copied in your clipboard.

Example:

    23:02test message

see element-hq#893
@richvdh
Copy link
Member

richvdh commented Jan 5, 2017

you'd need to make the colon invisible by default.

@rubo77
Copy link
Contributor Author

rubo77 commented Jan 5, 2017

how would you do that? I tried but I am not into that code so much.

Maybe you can provide a code snippet that solves this, I would update the PR then.

@rubo77
Copy link
Contributor Author

rubo77 commented Jan 5, 2017

Or a space instead of the colon would be fine too?

@richvdh
Copy link
Member

richvdh commented Jan 5, 2017

I guess you could put it in a zero-width span.

But actually, maybe it makes more sense to not include the timestamp at all?

@rubo77
Copy link
Contributor Author

rubo77 commented Jan 5, 2017

No, the timestamp is perfect on the copy clipboard

@richvdh
Copy link
Member

richvdh commented Jan 24, 2017

you can reopen this if you make the colon invisible by default.

@richvdh richvdh closed this Jan 24, 2017
@rubo77
Copy link
Contributor Author

rubo77 commented Jan 24, 2017

Or a space instead of the colon. would that be fine too?

@richvdh
Copy link
Member

richvdh commented Jan 24, 2017

I guess so

@rubo77
Copy link
Contributor Author

rubo77 commented Jan 24, 2017

I created a new PR: #3046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants