Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix right click menu in electron #6763

Merged
merged 2 commits into from
May 18, 2018
Merged

Fix right click menu in electron #6763

merged 2 commits into from
May 18, 2018

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented May 18, 2018 •
edited
Loading

giphy

Fixes #6762

lukebarnard1
lukebarnard1 reviewed May 18, 2018
View reviewed changes
Copy link
Contributor

@lukebarnard1 lukebarnard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment next to each case where we have to use {} would be great. Otherwise LGTM.

@dbkr dbkr merged commit e5fd579 into develop May 18, 2018
@t3chguy t3chguy mentioned this pull request May 18, 2018
Closed
@t3chguy t3chguy deleted the dbkr/fix_electron_menus branch May 12, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebarnard1 lukebarnard1 lukebarnard1 approved these changes

Assignees

@lukebarnard1 lukebarnard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @lukebarnard1