Setup Flipper. #43
Closed
Setup Flipper. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
requested review from
a team and
ganfra
and removed request for
a team
Generated by 🚫 dangerJS against f5b84c88be4c52b52ef4cd3ebb09432fa43c49d5 |
bmarty
force-pushed
the
feature/bma/flipper
branch
from
f5b84c8
to
d88104f
Compare
bmarty
commented
Jan 19, 2023
|
|
||
| class VectorFlipperProxy( | ||
| private val context: Context, | ||
| ) { |
There was a problem hiding this comment.
@ganfra I am not sure that adding this class with alter ego no-op versions is the best way to handle no-op version. WDYT?
There was a problem hiding this comment.
I'd say we have 2 options:
- do not call the initializer if not debug
- isEnabled could also check if it's debug or not ?
|
This tool does not bring a lot to the project, let's not add it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40
This is quite limited, since network on DB are handle by the Rust SDK, so this cannot really be plugged to Flipper. Also there is no Plugin to investigate Jetpack Compose structure (and this will not be supported by the core team, see facebook/flipper#2366).
Can still be useful to take screen shot or video, watch logs, inspect shared preferences and investigate crashes.
This PR set up the tool, so later we may add more plugins.