Fix multi-line reactions blocking message content #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
jonnyandrew
force-pushed
the
jonny/multi-line-reaction-bug
branch
from
dbbbbd9
to
5225b45
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #785 +/- ##
===========================================
- Coverage 56.88% 56.78% -0.11%
===========================================
Files 913 913
Lines 23159 23194 +35
Branches 4682 4682
===========================================
- Hits 13175 13170 -5
- Misses 7906 7945 +39
- Partials 2078 2079 +1
☔ View full report in Codecov by Sentry. |
jonnyandrew
force-pushed
the
jonny/multi-line-reaction-bug
branch
from
35998bc
to
d97cb8d
Compare
jonnyandrew
force-pushed
the
jonny/multi-line-reaction-bug
branch
from
3d065be
to
a80dc2d
Compare
jonnyandrew
commented
Jul 6, 2023
There was a problem hiding this comment.
The space between the emoji buttons has increased
jonnyandrew
commented
Jul 6, 2023
There was a problem hiding this comment.
Here is the new screenshot test
julioromano
approved these changes
Jul 6, 2023
…element-x-android into jonny/multi-line-reaction-bug
|
Kudos, SonarCloud Quality Gate passed! |
MatMaul
pushed a commit
that referenced
this pull request
Jul 6, 2023
Fixes #753 --------- Co-authored-by: ElementBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Screenshots