Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions layout improvements #912

Merged
merged 10 commits into from
Jul 21, 2023
Merged

Conversation

langleyd
Copy link
Member

What's in this PR

  • Add the custom reaction layout that only shows the expand UI after 2 lines.
  • It also enforces that the add more and expand buttons are always on the same line.
  • In LTR languages we want an incoming message's reactions to be LRT and outgoing to be RTL.
  • For RTL languages it should be the opposite.
  • Add more button should have primary text colour.

What does it look like

- Add the custom reaction layout that only shows the expand UI after 2 lines.
- It also enforces that the add more and expand buttons are always on the same line.
- In LTR languages we want an incoming message's reactions to be LRT and outgoing to be RTL.
- For RTL languages it should be the opposite.
@langleyd langleyd requested a review from a team as a code owner July 19, 2023 09:03
@langleyd langleyd requested review from ganfra and removed request for a team July 19, 2023 09:03
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link:

@jmartinesp
Copy link
Member

I've added a few commits to take care of lint issues, I hope you don't mind.

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 62.30% and no project coverage change.

Comparison is base (f32a177) 55.44% compared to head (404caed) 55.45%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #912   +/-   ##
========================================
  Coverage    55.44%   55.45%           
========================================
  Files          961      962    +1     
  Lines        24395    24462   +67     
  Branches      4951     4972   +21     
========================================
+ Hits         13526    13565   +39     
- Misses        8707     8726   +19     
- Partials      2162     2171    +9     
Impacted Files Coverage Δ
...s/impl/timeline/components/TimelineItemEventRow.kt 55.88% <0.00%> (-0.24%) ⬇️
...l/timeline/components/TimelineItemReactionsView.kt 49.09% <51.21%> (-12.25%) ⬇️
...timeline/components/TimelineItemReactionsLayout.kt 67.44% <67.44%> (ø)
...impl/timeline/components/MessagesReactionButton.kt 71.23% <100.00%> (+0.39%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@langleyd langleyd merged commit d9be396 into develop Jul 21, 2023
@langleyd langleyd deleted the feature/dla_custom_reactions_layout branch July 21, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants