Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotating screen loses draft msg #2364

Closed
ara4n opened this issue Jan 21, 2024 · 7 comments · Fixed by #2435
Closed

rotating screen loses draft msg #2364

ara4n opened this issue Jan 21, 2024 · 7 comments · Fixed by #2435
Assignees
Labels
A-Composer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Jan 21, 2024

Steps to reproduce

  1. Start writing a msg on iphone max
  2. Rotate the screen accidentally
  3. Lose the draft

Outcome

What did you expect?

don’t lose my drafts!!1!

Your phone model

iphone 12 pro max

Operating system version

17.2.1

Application version

493

Homeserver

No response

Will you send logs?

No

@stefanceriu
Copy link
Member

Strange, it should've been fixed in #2323

@stefanceriu
Copy link
Member

@ara4n the reported app version seems to be wrong, we're at 493 for nightlies and 86 for release 🤔

@stefanceriu
Copy link
Member

I was able to reproduce it but only on a large (max) iPhone. Presumably it has something to do with the split view appearing, recomputing the whole hierarcly and resetting that hasAlreadyAppeared ComposerToolbar flag

@stefanceriu stefanceriu added A-Composer T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 21, 2024
@stefanceriu
Copy link
Member

While we're at it let's also implement some sort of in-memory draft storage solution but do please put it behind a service and a protocol so we can switch to a rust based solution in the future (we need encryption if not in memory)

@stefanceriu
Copy link
Member

My original question still stands: why does the RTE need to reset its contents on appearance?

@ara4n
Copy link
Member Author

ara4n commented Jan 26, 2024

@ara4n the reported app version seems to be wrong, we're at 493 for nightlies and 86 for release 🤔

i strongly suspect i misread the 3 as an 8 on the dinky little icon (especially as i filed this in bed with my glasses off, hence accidentally rotating the phone :P)

@Velin92
Copy link
Member

Velin92 commented Feb 2, 2024

Opening an issue on RTE. I finally discovered what is causing it, but the solution requires to fix an architectural issue on the RTE side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
3 participants