Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: on iPad swapping apps resets the currently written text of the composer #2323

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 11, 2024

Fixes #2275

Simulator.Screen.Recording.-.iPad.Pro.12.9-inch.6th.generation.-.2024-01-11.at.15.17.49.mp4

@Velin92 Velin92 requested a review from a team as a code owner January 11, 2024 14:18
@Velin92 Velin92 requested review from pixlwave, stefanceriu and a team and removed request for a team January 11, 2024 14:18
Copy link

github-actions bot commented Jan 11, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 041aea9

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yey! 👏

@Velin92 Velin92 enabled auto-merge (squash) January 11, 2024 14:25
@Velin92 Velin92 force-pushed the mauroromito/fix_changing_app_resets_text branch from 8417961 to 041aea9 Compare January 11, 2024 14:35
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awwww nice! 👏👏👏

Great to see it fixed, this bug has been soooo annoying.

@Velin92 Velin92 merged commit 21fa5d1 into develop Jan 11, 2024
5 checks passed
@Velin92 Velin92 deleted the mauroromito/fix_changing_app_resets_text branch January 11, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In-progress messages do not persist if you view room info or navigate away from composer
3 participants