Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: RTE Speech to Text suddenly stops working #2114

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Fix: RTE Speech to Text suddenly stops working #2114

merged 2 commits into from
Nov 20, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 17, 2023 •
edited
Loading

fixes #2030

@Velin92 Velin92 requested a review from a team as a code owner November 17, 2023 19:01
@Velin92 Velin92 requested review from alfogrillo, stefanceriu and pixlwave and removed request for a team November 17, 2023 19:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against c5048d5

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

stefanceriu
stefanceriu approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Velin92 Velin92 merged commit fc7b003 into develop Nov 20, 2023
6 checks passed
@Velin92 Velin92 deleted the mauroromito/fix_speech_to_text branch November 20, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

@alfogrillo alfogrillo Awaiting requested review from alfogrillo alfogrillo is a code owner automatically assigned from element-hq/element-x-ios-reviewers

@pixlwave pixlwave Awaiting requested review from pixlwave

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using iOS's voice to text will stop transcribing pre-maturely
2 participants
@Velin92 @stefanceriu