Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering of rooms by name. #73

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Add filtering of rooms by name. #73

merged 4 commits into from
Jun 8, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jun 8, 2022

Part of #26, adds a search bar to the home screen that filters room by name.

Note: We should probably make the user avatar smaller as it imposes on the search bar a little bit on iPhone.

@pixlwave pixlwave requested a review from stefanceriu June 8, 2022 10:06
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4616d98

@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but please squash it on merge 👍

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Changes in 73 (2022-06-08)

✨ Features

  • Implement rageshake service. (#23)
  • Add filtering for rooms by name. (#26)
  • DesignKit: Add initial implementation of DesignKit to the repo as a Swift package. (#43)

🐛 Bugfixes

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/kaNCpt

@pixlwave pixlwave merged commit d7fae1a into develop Jun 8, 2022
@pixlwave pixlwave deleted the doug/room_search branch June 8, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants