Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto dismiss bug report when completed #83

Merged
merged 4 commits into from
Jun 20, 2022

Conversation

ismailgulek
Copy link
Contributor

Fixes #76

@ismailgulek ismailgulek requested review from a team and pixlwave and removed request for a team June 17, 2022 12:35
@github-actions
Copy link

github-actions bot commented Jun 17, 2022

Changes in 83 (2022-06-20)

✨ Features

  • Implement rageshake service. (#23)
  • Add filtering for rooms by name. (#26)
  • DesignKit: Add initial implementation of DesignKit to the repo as a Swift package. (#43)

🙌 Improvements

  • Add a UserSessionStore and the splash screen from Element iOS. (#40)
  • DesignKit: Add DesignKit to the ElementX project, style the login screen with it and tint the whole app. (#43)
  • Settings: Auto dismiss bug report screen and show a success indicator when bug report completed. (#76)
  • Bug report: Add GH labels. (#77)

🐛 Bugfixes

  • ElementInfoPlist: Use custom template for Info.plist. (#71)

🧱 Build

  • Use v0.0.1 of the DesignTokens package. (#78)

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/j29zNv

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #83 (1482b51) into develop (8653f1d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 1482b51 differs from pull request most recent head cd41244. Consider uploading reports for the commit cd41244 to get more accurate results

@@             Coverage Diff             @@
##           develop      #83      +/-   ##
===========================================
- Coverage    18.36%   18.36%   -0.01%     
===========================================
  Files          131      131              
  Lines         9638     9635       -3     
  Branches      4829     4825       -4     
===========================================
- Hits          1770     1769       -1     
+ Misses        7810     7808       -2     
  Partials        58       58              
Impacted Files Coverage Δ
...urces/Screens/BugReport/BugReportCoordinator.swift 45.23% <0.00%> (+4.81%) ⬆️
...Sources/Screens/BugReport/BugReportViewModel.swift 34.88% <ø> (-0.68%) ⬇️
...Sources/Screens/Settings/SettingsCoordinator.swift 33.92% <0.00%> (-2.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8653f1d...cd41244. Read the comment docs.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ismailgulek ismailgulek merged commit 40e51fb into develop Jun 20, 2022
@ismailgulek ismailgulek deleted the ismail/76_bug_report_dismiss branch June 20, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report screen should disappear after sending
3 participants