Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect home server from matrix id #810

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Detect home server from matrix id #810

wants to merge 22 commits into from

Conversation

Kaki-In
Copy link
Contributor

@Kaki-In Kaki-In commented Jul 21, 2022 •
edited
Loading

Detect home server from matrix id

Added functionnality :

  • you can now enter the user matrix id (e.g. @username:server.local) in the login input.
  • if the home server that you've entered into youre id is not the same that those into the home server input, it will be use instead to connect to the default matrix server.

Should fix this issue (#479).

@Kaki-In Kaki-In changed the title Detect hs from mxid Detect home server from matrix id Jul 21, 2022
bwindels
bwindels reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, haven't done a full review yet.

src/domain/login/PasswordLoginViewModel.js Outdated Show resolved Hide resolved
src/domain/login/PasswordLoginViewModel.js Outdated Show resolved Hide resolved
@Kaki-In
New corrections (from base of element-hq#810 pull request commentarie…
d75c937 
…s) :

 - fix methods miss;
 - corrected some identation mistakes.
@Kaki-In
Update about the serverName constant : missing the result id (from th…
c7c32a6 
…e regex)
@Kaki-In
Detected inattention mistake.
17730e8 
PasswordLoginViewModel.parseUsernameLogin() should return the username, not the servername.
@Kaki-In
Merge branch 'vector-im:master' into detect-hs-from-mxid
5542335
MidhunSureshR
MidhunSureshR reviewed Jul 26, 2022
View reviewed changes
Copy link
Member

@MidhunSureshR MidhunSureshR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and questions:

src/platform/web/ui/login/PasswordLoginView.js Outdated Show resolved Hide resolved
src/platform/web/ui/login/PasswordLoginView.js Outdated Show resolved Hide resolved
src/domain/login/PasswordLoginViewModel.js Outdated Show resolved Hide resolved
src/domain/login/PasswordLoginViewModel.js Outdated Show resolved Hide resolved
src/domain/login/PasswordLoginViewModel.js Outdated Show resolved Hide resolved
src/domain/login/PasswordLoginViewModel.js Outdated Show resolved Hide resolved
bwindels
bwindels reviewed Jul 27, 2022
View reviewed changes
src/platform/web/ui/login/PasswordLoginView.js Outdated Show resolved Hide resolved
src/matrix/common.js Outdated Show resolved Hide resolved
MidhunSureshR
MidhunSureshR reviewed Jul 29, 2022
View reviewed changes
Copy link
Member

@MidhunSureshR MidhunSureshR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more ts changes:

src/domain/login/LoginViewModel.ts Outdated Show resolved Hide resolved
src/domain/login/LoginViewModel.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MidhunSureshR MidhunSureshR MidhunSureshR left review comments

@bwindels bwindels bwindels left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support .well-known in the way the spec says
3 participants
@Kaki-In @bwindels @MidhunSureshR