Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limit to get_current_hosts_in_room #13659

Open
matrixbot opened this issue Dec 20, 2023 · 0 comments
Open

Add limit to get_current_hosts_in_room #13659

matrixbot opened this issue Dec 20, 2023 · 0 comments
Labels
A-Federation A-Messages-Endpoint A-Performance O-Uncommon S-Tolerable T-Enhancement

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 20, 2023 •
edited
Loading

This issue has been migrated from #13659.

Follow-up to matrix-org/synapse#13575. Part of matrix-org/synapse#13356

To improve things further we could add a limit parameter to get_current_hosts_in_room. Realistically, we don't need 4k domains to choose from because there is no way we're going to query that many before we a) probably get an answer or b) we give up.

-- Going further section in matrix-org/synapse#13575

This means we can do less work in the database which means less waiting to get a list of domains to try.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Federation A-Messages-Endpoint A-Performance O-Uncommon S-Tolerable T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot