Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add limit to get_current_hosts_in_room #13659

Open
Tracked by #15182
MadLittleMods opened this issue Aug 30, 2022 · 0 comments
Open
Tracked by #15182

Add limit to get_current_hosts_in_room #13659

MadLittleMods opened this issue Aug 30, 2022 · 0 comments
Labels
A-Federation A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) A-Performance Performance, both client-facing and admin-facing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Milestone
Faster /messages

Comments

@MadLittleMods
Copy link
Contributor

Follow-up to #13575. Part of #13356

To improve things further we could add a limit parameter to get_current_hosts_in_room. Realistically, we don't need 4k domains to choose from because there is no way we're going to query that many before we a) probably get an answer or b) we give up.

-- Going further section in #13575

This means we can do less work in the database which means less waiting to get a list of domains to try.
@MadLittleMods MadLittleMods added A-Federation A-Performance Performance, both client-facing and admin-facing A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) labels Aug 30, 2022
@MadLittleMods MadLittleMods mentioned this issue Aug 30, 2022
Merged
4 tasks
@DMRobertson DMRobertson added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 30, 2022
@kittykat kittykat mentioned this issue Oct 24, 2022
Closed
7 tasks
@kittykat kittykat mentioned this issue Mar 2, 2023
Closed
8 tasks
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Federation A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) A-Performance Performance, both client-facing and admin-facing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
Faster /messages
Development

No branches or pull requests
2 participants
@MadLittleMods @DMRobertson