Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rooms.bump_stamp to Sliding Sync /sync for easier client-side sorting #17395

Merged
merged 16 commits into from
Jul 8, 2024
Merged

Add rooms.bump_stamp to Sliding Sync /sync for easier client-side sorting #17395

merged 16 commits into from
Jul 8, 2024

Commits on Jul 3, 2024

  1. Add bump_stamp

    @MadLittleMods
    MadLittleMods committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    32b30b4 View commit details
    Browse the repository at this point in the history

  2. Get rid of extra room_id in tuple once sorted

    @MadLittleMods
    MadLittleMods committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    5a89eba View commit details
    Browse the repository at this point in the history

  3. Consider DEFAULT_BUMP_EVENT_TYPES

    @MadLittleMods
    MadLittleMods committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    7c3207b View commit details
    Browse the repository at this point in the history

  4. Add changelog

    @MadLittleMods
    MadLittleMods committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    176d023 View commit details
    Browse the repository at this point in the history

  5. Fix lints

    @MadLittleMods
    MadLittleMods committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    aee9619 View commit details
    Browse the repository at this point in the history

  6. Get rid of complexity 

    Also fixes problems when running with old Python (CI failure):
https://github.com/element-hq/synapse/actions/runs/9786096129/job/27020394279?pr=17395
```
builtins.AttributeError: 'Attribute' object has no attribute 'alias'
```
    @MadLittleMods
    MadLittleMods committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ef7a4d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Don't double document attributes 

    See #17395 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    b559bce View commit details
    Browse the repository at this point in the history

  2. Add bump_stamp to API response

    @MadLittleMods
    MadLittleMods committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    812a6e0 View commit details
    Browse the repository at this point in the history

  3. Revert back to sorting by the latest event 

    See #17395 (comment)

This better ensures that clients receive any new events
regardless of what they are.
    @MadLittleMods
    MadLittleMods committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    b59ccf7 View commit details
    Browse the repository at this point in the history

  4. Use correct live location share event type 

    See #17395 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    341283a View commit details
    Browse the repository at this point in the history

  5. Update changelog

    @MadLittleMods
    MadLittleMods committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    cee6091 View commit details
    Browse the repository at this point in the history

  6. Remove _RelevantRoomEntry complexity

    @MadLittleMods
    MadLittleMods committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    fc9f8a5 View commit details
    Browse the repository at this point in the history

  7. Prefer is not None

    @MadLittleMods
    MadLittleMods committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    76dce98 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into madlittlemods/sliding-sync-bump-stamp 

    Conflicts:
	synapse/handlers/sliding_sync.py
	synapse/types/handlers/__init__.py
    @MadLittleMods
    MadLittleMods committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    793d7dc View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge branch 'develop' into madlittlemods/sliding-sync-bump-stamp

    @MadLittleMods
    MadLittleMods committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1cc2c6b View commit details
    Browse the repository at this point in the history

  2. Slight correction to comment since we no longer sort on the serve by … 

    …bump types
    @MadLittleMods
    MadLittleMods committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    fac17cb View commit details
    Browse the repository at this point in the history